Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions on shadowrocket blacklist #55

Open
wyf88 opened this issue Nov 12, 2020 · 4 comments
Open

Suggestions on shadowrocket blacklist #55

wyf88 opened this issue Nov 12, 2020 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wyf88
Copy link

wyf88 commented Nov 12, 2020

First of all, thanks a lot for the project, which helps a LOT!! I just two minor suggestions on the rule of generating the shadowrocket blacklist, just for your consideration.

  1. Include rules of Apple/Google domains that are resolved to China IPs as DIRECT. Otherwise, domains like dl.google.com and icloud.cdn-apple.com will be proxied.
  2. Include IP ranges of Google. All should have been blocked, and given how many (sub)domains Google owns, it can be a good supplement of the domain-based rules. Here is a source that I can find.
@pexcn
Copy link
Owner

pexcn commented Nov 14, 2020

Thank you for your suggestions.

The first point may be completed in the next few months (also, pull request welcome 😁), I have been too busy lately, and I have almost no time to maintain the current project.

There are two problems with the second point:

  1. Need a stable data source, preferably from GitHub.
  2. Which domains or IPs have not been processed? Are there any logs?

@pexcn
Copy link
Owner

pexcn commented Nov 14, 2020

I think if accessing google is not through IP address, it should be processed by these lines:

___GFWLIST_PLACEHOLDER___

DOMAIN-KEYWORD,google,PROXY,force-remote-dns

If you want to add more IP addresses to the blacklist, it should cause performance issue. I asked the author of shadowrocket more than a year ago that its rule matching algorithm uses a trie tree, so I try to keep the shadowrocket rule list around 5000 lines.

In this case, it is generally recommended to use whitelist rules.

@pexcn pexcn added the enhancement New feature or request label Nov 15, 2020
@wyf88
Copy link
Author

wyf88 commented Nov 29, 2020

Thanks. Regarding the second point, at this moment I am not aware of any missed Google domains in gfwlist. However, new domains for new Google services can often be added, but the gfwlist may not be updated in time. On the other hand, the chunks of common Google IPs are almost unchanged (so it may not be a concern for a less frequent update) and short (the impact on performance should be very minor).

Edit: it seems there is an official list here.

@pexcn
Copy link
Owner

pexcn commented Nov 29, 2020

but the gfwlist may not be updated in time

I think this should be the upstream project needs to handle 😂.

Edit: it seems there is an official list here.

Good point, It may be added after a long time, I am too busy.

lists:

@pexcn pexcn added the good first issue Good for newcomers label Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants