Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flit instead of setuptools for ptyprocess (Teamcity CI). #327

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jquast
Copy link
Member

@jquast jquast commented Feb 14, 2016

This allows us to continue to test ptyprocess feature branches using pexpect,
introducing the new function make_wheel_for_ptyprocess and amending
existing code into prepare_environment, which installs the wheel file created
by flit.

this has gotten more complex, so we have made individual function units to
hopefully make it a bit more straight-forward to stumble into.

Note this does not effect our package, requires no version bump, release, or changelog item. This is used only by the mac/linux/freebsd build slaves

This allows us to continue to test ptyprocess feature branches using pexpect,
introducing the new function make_wheel_for_ptyprocess and amending
existing code into prepare_environment, which installs the wheel file created
by flit.

this has gotten more complex, so we have made individual function units to
hopefully make it a bit more straight-forward to stumble into
@takluyver
Copy link
Member

Thanks for working out how to do this! I can't deny that this is a fair bit of extra complexity for our custom test script, though. I'm obviously rather fond of my own packaging tool, but I won't be offended if you'd rather merge pexpect/ptyprocess#32 and go back to the conventional tools until/unless a new standard is hammered out. The intent is not to make things like this more complex!

@takluyver
Copy link
Member

PS I'm turning in for the night on this side of the pond, so I won't see what happens until tomorrow morning. Enjoy your long weekend!

@takluyver
Copy link
Member

It may affect this decision that there are a couple of PEPs in the works (516, 517) to define new sdist formats, which flit would support. Neither of them are moving very quickly, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants