dont remove reference to _UnixReadPipeTransport #376
Conversation
_UnixReadPipeTransport class closes pipe in __del__ method. This commit adds attribute to SpawnBase with pointer to current transport.
| class PatternWaiter(asyncio.Protocol): | ||
| transport = None | ||
| def __init__(self, expecter): | ||
|
|
||
| def set_expecter(self, expecter): |
There was a problem hiding this comment.
I don't really like this pattern of having a non-constructor method which must be called before other methods will work.
I've probably used asyncio wrong in some way when writing this code, but I don't really have the time or interest to work out the right way to do it at the moment.
There was a problem hiding this comment.
I think that you can apply this workaround with "no-like" pattern and resolve critical bug. When you got more free time you can make more accurate resolution of this problem. At this time expect() with "async" option totally unusable. Also need to rename async because in python 3.5 async is name of operator.
There was a problem hiding this comment.
Why can't the expecter be passed to the constructor? Was the constructor removed so that the super class constructor would be called instead? I don't understand this change. Ok. I looked at the usage some more. I see that if the async_pw_transport is already set, the set_expecter method is used to set the expecter. Why can't the constructor call set_expecter?
There was a problem hiding this comment.
Because instance of PatternWaiter should not be destroyed. If this happens socket will be closed. So i save PatternWaiter instance in SpawnBase instance.
|
Hi there, I would really like to see this code merged in. Thanks! |
|
OK, there's little point in holding out for a better solution if I'm not prepared to work on one. |
_UnixReadPipeTransport class closes pipe in del method. This commit
adds attribute to SpawnBase with pointer to current transport.