closes issue #42, self.buffer decoded implicitly #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create a unit tests which otherwise failed for python3 only: mock the return value of set_unique_prompt for a value of False, which causes ExceptionPxssh to raise. previously, displaying self.buffer within the exception causes bytes() to be implicitly decoded to str (unicode type in py3). python2 didn't care. it is implicitly decoded as 'ascii' encoding, without warning. Then, use the %r to represent it as b'xyz' in python3. Also, display what we expected to be more helpful for the user. What is actually happening here is the 'set PS1=' command is used so that pexpect can more regularly understand when the prompt is awaiting command input, and it is set to something more predictable. You'd be suprised what kind of hackery can happen to prompt values even if PS1 is explicitly set, especially in today's oh-my-zhs and git-prompt.sh extensions.
| raise ExceptionPxssh('could not set shell prompt\n'+self.before) | ||
| raise ExceptionPxssh('could not set shell prompt ' | ||
| '(recieved: %r, expected: %r).' % ( | ||
| self.before, self.PROMPT_SET_SH,)) |
There was a problem hiding this comment.
expected self.PROMPT, not self.PROMPT_SET_SH. PROMPT_SET_SH is the command it sends to try to change the prompt.
|
Other than that, this looks good. |
completes issue #44; thanks to @takluyver for keen eye.
jquast
added a commit
that referenced
this pull request
Mar 8, 2014
…-str closes issue #42, self.buffer decoded implicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create a unit tests which otherwise failed for python3 only: mock the
return value of set_unique_prompt for a value of False, which causes
ExceptionPxssh to raise.
previously, displaying self.buffer within the exception causes
bytes() to be implicitly decoded to str (unicode type in py3). python2
didn't care. it is implicitly decoded as 'ascii' encoding, without
warning.
Then, use the %r to represent it as b'xyz' in python3. Also, display
what we expected to be more helpful for the user. What is actually
happening here is the 'set PS1=' command is used so that pexpect can
more regularly understand when the prompt is awaiting command input, and
it is set to something more predictable. You'd be suprised what kind of
hackery can happen to prompt values even if PS1 is explicitly set,
especially in today's oh-my-zhs and git-prompt.sh extensions.