replwrap: add async support #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasFaivre
force-pushed
the
repl_async
branch
2 times, most recently
from
77b17f7
to
ea893a6
Compare
takluyver
reviewed
Jun 17, 2018
pexpect/replwrap.py
Outdated
| def _run_line(fut=None): | ||
| if len(cmdlines) < cmd_count: | ||
| # gather output after the first line has been sent | ||
| out.append(self.child.before) |
There was a problem hiding this comment.
This async recursive structure is not very easy to follow, in my opinion. Would it be better written as a coroutine?
Add an 'async_' argument to run_command. When True, a coroutine will be returned which *must* be awaited in asynchronous code. Signed-off-by: Robin Jarry <robin.jarry@6wind.com> Signed-off-by: Thomas Faivre <thomas.faivre@6wind.com>
Signed-off-by: Thomas Faivre <thomas.faivre@6wind.com>
|
Thanks for the very good point @takluyver |
|
Hello! Thanks! |
|
Looks good to me, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an 'async_' argument to run_command. When True, a Future object will
be returned which must be awaited in asynchronous code.
Signed-off-by: Robin Jarry robin.jarry@6wind.com
Signed-off-by: Thomas Faivre thomas.faivre@6wind.com