Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure we're dealing with strings #556

Closed
wants to merge 1 commit into from
Closed

Conversation

kcr
Copy link

@kcr kcr commented Feb 5, 2019

This seems to be necessary to make .interact() work under certain circumstances.

@kcr
Copy link
Author

kcr commented Feb 5, 2019

headdesk or maybe I was using it wrong.

@takluyver
Copy link
Member

That doesn't look quite right. The log files should get bytes data if the spawn object doesn't have a specified encoding, and unicode data if it does (docs).

It looks like the interact machinery is sending bytes to the log files regardless of whether there's a specified encoding. You don't need to decode the data to pass it between stdin and the child terminal, but that introduces an inconsistency in the way the data is logged.

@Red-M Red-M closed this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants