Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add history URL to project metadata #644

Merged
merged 1 commit into from
May 16, 2020
Merged

Add history URL to project metadata #644

merged 1 commit into from
May 16, 2020

Conversation

scop
Copy link
Contributor

@scop scop commented May 9, 2020

Background info at
pypi/warehouse#7882 (comment)

@takluyver
Copy link
Member

Thanks!

@takluyver takluyver merged commit 5da50dc into pexpect:master May 16, 2020
@takluyver
Copy link
Member

I belatedly noticed that history wasn't one of the options you added in your Warehouse PR. Do you want to make another PR here to change the name to changelog or something?

@scop
Copy link
Contributor Author

scop commented May 17, 2020

I have another warehouse PR pending for that: pypi/warehouse#7896

In any case, I think the link should match the title of the thing it links to, so in that sense I think it's fine as is. But personally I'd use "Changelog" or "Change log" (IIRC the former is more common) in both the link and the doc if I was starting a project, not sure if it's worth tweaking once it's out like it is in this case (there's also the history.html filename to consider, so... meh).

@scop scop deleted the history-url branch May 17, 2020 09:29
@scop
Copy link
Contributor Author

scop commented May 17, 2020

Note BTW that currently History as the title will work just fine too, warehouse will just show the readthedocs icon for it until the mentioned PR is merged.

@takluyver
Copy link
Member

OK, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants