Ensure test_run.py works when system-wide bashrc produces output #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --rcfile option to bash does not prevent the system-wide /etc/bash.bashrc script from running (contrary to the Debian man-page). This causes test_run.py to fail when the system-wide script produces output (as is the case in an Ubuntu image where the regular user belongs to the "sudo" group and the system-wide script produces an informational message about sudo usage). Rather than rely on --rcfile, this patch changes the test to use --norc (which does suppress the execution of the system-wide bashrc), and changes PS1 via the inherited environment instead (this also slightly simplifies the fixture setup too as tempfile is no longer required).
|
Apologies, re-opening is the only way to get github to realise it needs to run the test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--rcfileoption to bash does not prevent the system-wide/etc/bash.bashrcscript from running (contrary to the Debian man-page). This causestest_run.pyto fail when the system-wide script produces output (as is the case in an Ubuntu image where the regular user belongs to the "sudo" group and the system-wide script produces an informational message aboutsudousage).Rather than rely on
--rcfile, this patch changes the test to use--norc(which does suppress the execution of the system-wide bashrc), and changesPS1via the inherited environment instead (this also slightly simplifies the fixture setup too astempfileis no longer required).