Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.5, 3.6 and 3.12.0-rc.1 to test matrix #763

Merged
merged 1 commit into from Sep 29, 2023

Conversation

fcollonval
Copy link
Contributor

@fcollonval fcollonval commented Aug 8, 2023

Closes #762

This adds:

  • test against Python 3.5, 3.6 and 3.12.0-rc.1

@fcollonval
Copy link
Contributor Author

@Red-M all tests are green on the additional Python version; see fcollonval#1

Is there something more to do? Are there tests in tests/test_async.py missing?

@Red-M
Copy link
Member

Red-M commented Aug 8, 2023

Yes, there was new features added in #732 and they need to have tests written for them

@fcollonval
Copy link
Contributor Author

Thanks @Red-M for the reply - I'm gonna need some help to be sure to get it right.

Looking at the coverage, there is 8 lines missed in both _async_*_await.py that correspond to

image

Coverage for Python 3.10 (but result is similar for other Python version).

Those lines are missing coverage prior to #732.

Could you provide pointers on what to do? There is the maintenance suggested in #752, is there something else?

@Red-M Red-M marked this pull request as ready for review September 29, 2023 09:20
@Red-M Red-M closed this Sep 29, 2023
@Red-M Red-M reopened this Sep 29, 2023
@Red-M Red-M merged commit c0296ca into pexpect:master Sep 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for new release
2 participants