Create icons directly from pdf data #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -945,8 +1013,7 @@ CGImageRef CGImageCreateMaskFromPDFNamed(NSString *pdfName, CGSize size) | |||
| CGContextTranslateCTM(context, 0.0f, -mediaRect.size.height); | |||
|
|
|||
| // Draw pdf | |||
| CGContextDrawPDFPage(context, firstPage); | |||
| CGPDFDocumentRelease(pdf); | |||
There was a problem hiding this comment.
Hmm, was this line unnecessary? Or accidental deletion?
There was a problem hiding this comment.
I left the CGPDFDocumentRelease(pdf); within the caller (e.g. Line 969 and 992) mostly because I try to keep memory management as local as possible (no hidden release calls without explicitly mentioning them in docs).
There was a problem hiding this comment.
Ah thanks, silly question. I shouldn't have read just the diff.
|
Looks great, thanks! Check out my comment on line 949 above btw. |
peyton
pushed a commit
that referenced
this pull request
Jul 29, 2012
Create icons directly from pdf data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently had the use case of loading icons dynamically using a web service.
In order to use your library I added the ability to load pdfs directly from NSData.
Maybe this could be beneficial to others as well.