Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cascade delete for prompt #84

Merged
merged 2 commits into from
Jun 17, 2023
Merged

feat: add cascade delete for prompt #84

merged 2 commits into from
Jun 17, 2023

Conversation

120axuz
Copy link
Collaborator

@120axuz 120axuz commented Jun 14, 2023

This PR adds the ability to delete a prompt. The deletion action cascades and removes all other entities that are related and tied to the prompt entity.
The new delete button can be found in the settings tab (new)

arielweinberger
arielweinberger requested changes Jun 15, 2023
View reviewed changes
Copy link
Member

@arielweinberger arielweinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, just a few minor changes.

apps/server/src/app/prompts/prompts.resolver.ts Outdated Show resolved Hide resolved
apps/server/src/app/analytics/events.types.ts Outdated Show resolved Hide resolved
@arielweinberger arielweinberger self-requested a review June 17, 2023 16:20
@120axuz 120axuz merged commit af32898 into feature/org-members-invitations Jun 17, 2023
@120axuz 120axuz deleted the feature/delete-prompt branch June 17, 2023 16:23
arielweinberger added a commit that referenced this pull request Jun 17, 2023
@arielweinberger @120axuz @ItayElgazar
feat: ci dispatch event
547a9c2 
* feat: invitation creation, listing, deletion and acceptance

* refactor: breadcrumbs

* implement orgs wrapper

* fetch projects by organization ID

* cleanup

* org member + invitations management

* implement org settings + rename

* reset settings after save

* permissions by org rather than project

* remove project memberships

* add kafka and org invitation sent event

* make kafka module more robust

* fix formatting

* feat: hide org settings page from member users

* feat: move api keys to organization level

* feat: use role dropdown to change invited member role

* org invitations

* gitmodules

* set font-weight of headings to 400

* fix imports

* fix formatting

* fix kafka offline schema generation

* add scripts folder to tsconfig

* remove redundant function

* fix kafka producer connect

* chore: code tweaks & folder restructure (#87)

* chore: code tweaks & folder restructure

* delete docker

* chore: add more logs

* chore: add more logs

* chore: remove redandunt if

* chore: change orgs

* change logs

* fix: build

* fix: fix issue with wrong org fetched from local storage (#88)

* fix: handle errors

* feat: add cascade delete for prompt (#84)

* feat: add cascade delete for prompt

* fix: linting

* test dispatch

* test dispatch

* test dispatch

* test dispatch with payload

* test with submodule

* sync submodule

* rename CI event

* update submodule

* update submodule version

* update pezzo-private submodule

* update submodule

* update submodule

* add docker metadata

* update submodule

* delete entrypoint, update submodule

* remove entrypoint

* update submodule

* update submodules

* update submodule

* add short sha

* remove short sha

* update ci and submodules

* update submodule

* emit shortSha in event

* fix short sha emission

* fix short sha

* make short sha

* update varaibles

* fix formatting

---------

Co-authored-by: 120axuz <ran@pezzo.ai>
Co-authored-by: Itay Elgazar <Itayekk1@gmail.com>
Co-authored-by: 120axuz <136251517+120axuz@users.noreply.github.com>
@arielweinberger arielweinberger mentioned this pull request Jun 17, 2023
Closed
ItayElgazar added a commit that referenced this pull request Jun 21, 2023
@ItayElgazar @arielweinberger @120axuz
release/0.3.0 (#95)
4e465fa 
* feat: invitation creation, listing, deletion and acceptance

* refactor: breadcrumbs

* implement orgs wrapper

* fetch projects by organization ID

* cleanup

* org member + invitations management

* implement org settings + rename

* reset settings after save

* permissions by org rather than project

* remove project memberships

* add kafka and org invitation sent event

* make kafka module more robust

* fix formatting

* feat: hide org settings page from member users

* feat: move api keys to organization level

* feat: use role dropdown to change invited member role

* org invitations

* gitmodules

* set font-weight of headings to 400

* fix imports

* fix formatting

* fix kafka offline schema generation

* add scripts folder to tsconfig

* remove redundant function

* fix kafka producer connect

* chore: code tweaks & folder restructure (#87)

* chore: code tweaks & folder restructure

* delete docker

* chore: add more logs

* chore: add more logs

* chore: remove redandunt if

* chore: change orgs

* change logs

* fix: build

* fix: fix issue with wrong org fetched from local storage (#88)

* fix: handle errors

* feat: add cascade delete for prompt (#84)

* feat: add cascade delete for prompt

* fix: linting

* test dispatch

* test dispatch

* test dispatch

* feat: type safety through kafka lib (#89)

* feat: ci dispatch event (#91)

* test dispatch with payload

* test with submodule

* sync submodule

* rename CI event

* update submodule

* update submodule version

* update pezzo-private submodule

* update submodule

* update submodule

* add docker metadata

* update submodule

* delete entrypoint, update submodule

* remove entrypoint

* update submodule

* update submodules

* update submodule

* add short sha

* remove short sha

* update ci and submodules

* update submodule

* emit shortSha in event

* fix short sha emission

* fix short sha

* make short sha

* update varaibles

* fix formatting

* enable source maps

* clearner way to build with sourcemaps

* test build libs from source

* add ^build dependency to console

* add reflect-metadata

* feat: logout page

* cleanup localstorage org id when signing out

* use Pezzo ID rather than supertokens ID

* use plural private member for service

* update submodule

* fix: formatting

* fix: dependencies

* update submodule

* feat: add supertokensUserId to RequestUser interface

* fix: formatting

* temporarily allow circular dependency for @pezzo/kafka

* fix formatting

* feat: new UI look (#94)

* feat: new Pezzo brand look

* sync submodules

* feat(readme): new look

* update image

* reduce logo size on readme

* reimplement org selector

* fix: hide create project for non admins (#93)

* fix: hide create project buttons for non admin users

* fix: import

* fix: admin org

* remove org admin import

* fix: remove pascal case from prompt name

* fix: remove role & prevent from invite yourself

* fix: wrong if statement

* chore: add gpt-3.5-turbo-16k

* feat: add new openai model settings

* fix: update openai's cost

* fix: ai21 labs schema & change initial editor value to be text

* chore: update format

* chore: bump versions

---------

Co-authored-by: Ariel Weinberger <weinberger.ariel@gmail.com>
Co-authored-by: 120axuz <136251517+120axuz@users.noreply.github.com>
ItayElgazar pushed a commit that referenced this pull request Jun 28, 2023
@120axuz @ItayElgazar
feat: add cascade delete for prompt (#84)
b2267a5 
* feat: add cascade delete for prompt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItayElgazar ItayElgazar ItayElgazar left review comments

@arielweinberger arielweinberger arielweinberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@120axuz @arielweinberger @ItayElgazar