Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions not found when using decorated annotations #347

Closed
robzienert opened this issue Nov 11, 2019 · 5 comments
Closed

Extensions not found when using decorated annotations #347

robzienert opened this issue Nov 11, 2019 · 5 comments

Comments

@robzienert
Copy link

It looks like PF4J's @Extension annotation cannot be put onto another annotation.

My project is looking to add additional metadata and PF4J does not appear to find any extensions that use our @SpinnakerExtension annotation:

@Extension
@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.TYPE)
@Documented
public @interface SpinnakerExtension {
}

The SpinnakerExtension annotation has additional fields which are required for our project to process things correctly. The workaround for the moment, is to include both annotations on an extension, but this is undesirable as a long-term solution.

@decebals
Copy link
Member

If I understand correctly, this issue is identical with the feature describes here.

decebals added a commit that referenced this issue Nov 14, 2019
# Conflicts:
#	pf4j/src/main/java/org/pf4j/processor/ExtensionAnnotationProcessor.java
#	pf4j/src/test/java/org/pf4j/ExtensionAnnotationProcessorTest.java
@decebals
Copy link
Member

@robzienert, @tylerhawkes
I think that I solved this feature request (see PR #348). I published a new SNAPSHOT that contains this feature.
Can you test it please?
If you use Maven in your project(s), please take a look at doc to find how to use SNAPSHOT in your project(s).

@decebals
Copy link
Member

@robzienert @tylerhawkes
My intention is to release a new version soon, that mainly will contain this feature and #289. In this context, do you think this problem is solved (with what we have on the master's branch) or do you expect more?

@jonsie
Copy link

jonsie commented Nov 27, 2019

@decebals This release looks like it will achieve the original request here - thank you!

@decebals
Copy link
Member

This feature is included in the latest release (3.2.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants