add automatic module name to pf4j.jar #275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this recommendation the
pf4j.jar
file should provide anAutomatic-Module-Name
in itsMANIFEST.MF
. This pull requests extends thepom.xml
in order to add the lineto the
MANIFEST.MF
ofpf4j.jar
(see this commit). In case PF4J is migrated to Jigsaw (Java 9+) in the future, you can useorg.pf4j
in themodule-info.java
without getting conflicts with application, that already make use of Jigsaw (Java 9+).I didn't make any changes to the demo application. Because in most cases the demo libraries aren't reused by other applications.