Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add automatic module name to pf4j.jar #275

Merged
merged 5 commits into from Jan 14, 2019

Conversation

pinhead84
Copy link
Contributor

@pinhead84 pinhead84 commented Jan 13, 2019

According to this recommendation the pf4j.jar file should provide an Automatic-Module-Name in its MANIFEST.MF. This pull requests extends the pom.xml in order to add the line

Automatic-Module-Name: org.pf4j

to the MANIFEST.MF of pf4j.jar (see this commit). In case PF4J is migrated to Jigsaw (Java 9+) in the future, you can use org.pf4j in the module-info.java without getting conflicts with application, that already make use of Jigsaw (Java 9+).

I didn't make any changes to the demo application. Because in most cases the demo libraries aren't reused by other applications.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 455

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 52.613%

Totals Coverage Status
Change from base Build 454: -0.1%
Covered Lines: 906
Relevant Lines: 1722

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 455

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 52.613%

Totals Coverage Status
Change from base Build 454: -0.1%
Covered Lines: 906
Relevant Lines: 1722

💛 - Coveralls

@decebals decebals merged commit 0783532 into pf4j:master Jan 14, 2019
@pinhead84 pinhead84 deleted the automatic-module-names branch March 23, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants