Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the plugins in the demo did not load successfully #276

Merged
merged 1 commit into from Jan 16, 2019
Merged

Fix the plugins in the demo did not load successfully #276

merged 1 commit into from Jan 16, 2019

Conversation

packbase
Copy link
Contributor

@packbase packbase commented Jan 16, 2019

I tried running run-demo.sh and found that the results were not correct: WelcomePlugin and HelloPlugin could be loaded, but the extensions didn't work.

The log message:

Found 1 extensions for extension point 'org.pf4j.demo.api.Greeting'
>>> Whazzup

WelcomePlugin.start()
HelloPlugin.start()

HelloPlugin.stop()
WelcomePlugin.stop()

I found it was due to a modification of a commit: 254c9cc

The log after the repair is:

Found 3 extensions for extension point 'org.pf4j.demo.api.Greeting'
>>> Whazzup
>>> Welcome
>>> Hello

WelcomePlugin.start()
HelloPlugin.start()

HelloPlugin.stop()
WelcomePlugin.stop()

Thanks.

packbase referenced this pull request Jan 16, 2019
@packbase packbase changed the title Fix the plugins in the demo example did not load successfully Fix the plugins in the demo did not load successfully Jan 16, 2019
@decebals decebals merged commit b03d327 into pf4j:master Jan 16, 2019
@decebals
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants