adds equals/hashCode to some data classes #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have extended DefaultPluginDescriptor to add some extra attributes and not having equals/hashCode implemented makes it a bit tough to write good tests around our PluginDescriptorFinder implementation. This just adds IntelliJ generated equals and hashCode to DefaultPluginDescriptor, PluginDependency, and PluginClasspath.
|
I had a bit of trouble getting the project in a happy state locally to run the full test suite but hopefully travis-ci has my back ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have extended DefaultPluginDescriptor to add some extra attributes
and not having equals/hashCode implemented makes it a bit tough to
write good tests around our PluginDescriptorFinder implementation.
This just adds IntelliJ generated equals and hashCode to
DefaultPluginDescriptor, PluginDependency, and PluginClasspath.