#394, keep dependent when unload plugin #416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decebals
reviewed
Jan 7, 2021
| @@ -275,7 +275,7 @@ protected boolean unloadPlugin(String pluginId, boolean unloadDependents) { | |||
| if (unloadDependents) { | |||
| List<String> dependents = dependencyResolver.getDependents(pluginId); | |||
| while (!dependents.isEmpty()) { | |||
| String dependent = dependents.remove(0); | |||
| String dependent = dependents.get(0); | |||
There was a problem hiding this comment.
I like the change because is very light.
Did you tested? I ask you because at first glance, this change produces an infinite loop (dependents will never be empty and the while block will be executed forever).
|
ops...I didn't notice that and left it to unit test (all passed...) leave it for a while, I will rewrite it and add some unit test to cover the case. |
|
@decebals updated. also add unit test: PluginDependencyTest.dependentStop |
decebals
reviewed
Jan 8, 2021
| @@ -274,8 +274,7 @@ protected boolean unloadPlugin(String pluginId, boolean unloadDependents) { | |||
| try { | |||
| if (unloadDependents) { | |||
| List<String> dependents = dependencyResolver.getDependents(pluginId); | |||
| while (!dependents.isEmpty()) { | |||
| String dependent = dependents.remove(0); | |||
| for (String dependent : dependents) { | |||
| unloadPlugin(dependent, false); | |||
| dependents.addAll(0, dependencyResolver.getDependents(dependent)); | |||
There was a problem hiding this comment.
I think that this line will produce in the end a java.util.ConcurrentModificationException.
|
I see something related to this issue. It's about #250. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #394. Not sure will this change break other place.