A few more unit tests #73
Conversation
|
I am so happy when I see a new unit test 😄 I try to learn as much as possible from this project. I am sure that we must modified (a little bit) the project code to facilitate the creation of unit tests. |
|
My experience in unit testing is also not very high so any suggestions are welcome. |
| @@ -51,10 +51,10 @@ public DefaultExtensionFinder(PluginManager pluginManager, ExtensionFactory exte | |||
| } | |||
|
|
|||
| log.debug("Finding extensions for extension point '{}'", type.getName()); | |||
| readIndexFiles(); | |||
| Map<String, Set<String>> cachedEntries = readIndexFiles(); | |||
There was a problem hiding this comment.
I don't understand this modification. What was wrong in the previous version?
There was a problem hiding this comment.
It was to make it easy to test but if you have another suggestion I can revert this.
There was a problem hiding this comment.
Can you do a rebase please. I modified the class a little bit to improve the testability.
Maybe this link help. |
|
Just browsing this project to consider it for use. Why is this and two other PR's still open since 2015? I would expect them to be either merged or closed? |
|
@janhoy
Right now for me it's important to merge #128, because this PR comes with useful things and it contains some refactored code. After I release the next version (in few days), I will try to take a look over these old PR/issues and to come with a resolution. |
|
+1 |
|
I have been very busy but I will try to update the pull request soon. |
| @@ -0,0 +1,152 @@ | |||
| /* | |||
| * Copyright 2015 Mario Franco. | |||
There was a problem hiding this comment.
Please change the copyright (they are some files in this PR).
|
The tests need to be updated I will tell you when it's OK to merge it |
|
@lightglitch I was the impression that you made some changes 😄 |
|
@lightglitch With your permission, I will integrate these tests in master. |
|
Resolved by 0a0513b. |
Don't know what is the best option to test the private methods of DefaultExtensionFinder ...