Further tweaks and small updates. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
April 13, 2021 19:23
The corresponding addresses are stored in the 'userdata'. It's less direct, but allows the user to see a much friendlier option. It means that if there are only two correct addresses, the possibility of a user inserting incorrect values is removed (and the need for validation is similarly removed). Related to this: reading the config file is now pulled out into a separate function that returns default values on any file read errors.
…g information. QTextEdit.toPlainText returns the contents as plain text, rather than switching it to plain text most: QPlainTextEdit must be used for that instead.
Not hugely important, but such consi8stency ensures a better UX.
"using" -> "uses" for tense consistency. remove "either" since there are more than two interfaces.
…nly text edit. This allows the dialog to be smaller. With triple-quoted strings, even the indenting whitespace is included as part of the string, so they need to sit against the left-hand side of the file. It's a bit ugly, but c'est la vie :)
It's good practice to reduce the scope of variables as much as possible, and it turns out ptflasher.filedialog can be turned into a local variable inside ptflasher.filesearch.
This makes the order of definitions consistent with their appearence in the dialog itself, and consistency is (almost) always helpful :)
It's idiomatic to just say "if variable:" rather than "if variable != ''".
|
At first glance, nothing is jumping out and the code is certanly a lot cleaner than it was. Not to cast blame (as my Pythonese isn't that great either) but I did wonder what Electr0 was thinking with some of that code. xD I'll try it on Windows tomorrow, but it is looking better on Linux, and working just fine still. Not that it matters, but I think the config dialog can be a little shorter now? |
|
And don't be concerned about offending... all suggestions and constructive criticisms are welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes:
Please take these as they are intended: as (hopefully helpful!) suggestions for improvements, rather than criticism of your work. I'm happy to discuss any of the changes.