Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Use url_to_postid instead of text comparison for in-reply-to #44

Closed
singpolyma opened this issue Oct 15, 2015 · 3 comments
Closed

Use url_to_postid instead of text comparison for in-reply-to #44

singpolyma opened this issue Oct 15, 2015 · 3 comments

Comments

@singpolyma
Copy link

Instead of checking that the in-reply-to links link to the exact permalink of the post the comment is on, I propose instead checking if the post_ID we get from url_to_postid on the in-reply-to link matches the local post_ID -- this would allow for more flexibility for the format of the link on the remote (eg, both ?p= and rewrite forms would work).

@pfefferle pfefferle self-assigned this Oct 19, 2015
@pfefferle
Copy link
Owner

Great idea!

@dshanske
Copy link
Collaborator

This is good, but might cause a fragment issue. Will look

@stale
Copy link

stale bot commented Apr 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 1, 2022
@stale stale bot closed this as completed Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants