Semantic_linkbacks_type returning incorrectly

[colin-walker]

Issue: the semantic_linkbacks_type function is returning "mention" instead of "like"

Like received here:
https://colinwalker.blog/2017/04/19/sonant-thoughts-episode-11-preparation-and-nerves/

From here:
http://stream.boffosocko.com/2017/liked-colin-walkers-sonant-thoughts-episode-11-preparation-and-nerves

Relevant plugins installed:
IndieWeb
Webmention
Semantic Linkbacks

[colin-walker]

I currently have the function filtering for "mention" which is why the like shows.

[miklb]

@colin-walker just to confirm, have you checked to make sure that webmention is indeed stored as a like? I've had backfeed from boffosocko come in as only a mention myself, when it was supposed to be a reply. Was mentioned that could be an issue with Known.

[colin-walker]

@miklb Maybe that's it - it does seem to be stored as mention. If I set my comment walker for a null type then check semantic_linkbacks_type for what's returned it says "mention" rather than like. Didn't know if it was a local issue or not.

[colin-walker]

After some more testing it does look like this is what's happening. The issue does appear to be with how Known has sent the 'like'.

This can be closed.

[colin-walker]

Re-opening as requested.

[miklb]

@colin-walker at leasts it is good to know now that it's how the mention is stored vs the function itself returning improperly.

[miklb]

per the discussion in #indieweb IRC, a test suite was mentioned later that could be of benefit.

https://github.com/microformats/tests

[gRegorLove]

The like-of property appears to be parsed correctly in @chrisaldrich's post, so I do think this is in one of the WP plugins: http://pin13.net/mf2/?url=http%3A%2F%2Fstream.boffosocko.com%2F2017%2Fliked-colin-walkers-sonant-thoughts-episode-11-preparation-and-nerves

[pfefferle]

@miklb the test suite does not help here, because the parser has no issues. It is a problem how the plugin interprets the result of the parser.

@gRegorLove I might have said parser, but what I meant was interpreter... the parsing is OK, but the like-of is in a place where the plugin does not recognize it.

[snarfed]

subscribing with a vengeance. this has plagued me for years now. can't wait to see it fixed!

examples: https://snarfed.org/2017-03-12_23853#comment-2603533
(both emoji reactions, but i've seen normal replies trigger it too.)

reaction example that didn't trigger it, on the same post: https://snarfed.org/2017-03-12_23853#comment-2603372

IRC discussion: https://chat.indieweb.org/2017-04-30#t1493587145707000

...and sorry, these aren't likes, so they're a bit different, but i strongly suspect the same root cause.

[chrisaldrich]

@snarfed This may sound crazy, but I used to see something like this issue until I uninstalled the uf2 plugin. I couldn't guarantee it was the cause as I couldn't pin it down exactly, but since uninstalling it, I haven't seen it since. cross reference: pfefferle/wordpress-webmention#97 (comment)

[snarfed]

@chrisaldrich interesting! that would be sad if so. i definitely plan to keep using uf2, so if it's the cause, we should definitely find and fix the bug.

[pfefferle]

the problem is that I no longer selfdogfooding the uf2 plugin, but I am open to add new contributors.

[dshanske]

Should be addressed by #85

[dshanske]

Believe this can be closed now with latest merge.

[pfefferle]

@colin-walker can you verify this?

[colin-walker]

Will keep an eye on it and let you know.

[dshanske]

Poke?

[snarfed]

i haven't seen this for a while. I'm ok with closing.