Mf2 Improvements #85
Mf2 Improvements #85
Conversation
|
This example https://github.com/voxpelli/node-webmention-testpinger/blob/master/templates/notizblog-org.html results in |
|
h-card is not detected on https://github.com/voxpelli/node-webmention-testpinger/blob/master/templates/sandeep-io.html |
|
Needs improvement on the authorship side, as noted. Will continue there. How do the changes look otherwise? |
|
I built in the ?sldebug query to test examples also. |
|
If it is working at the end, I am fine with all your changes ;) |
|
Thanks for your work! |
|
I am going to keep working at authorship to improve it. So far, in testing the URLs that people reported issues with, it is now correctly classifying things, so we'll move from there. |
|
Still working the scenario of an h-cite nested in a like-of. But the rest should be improved. |
|
OK, just remove the |
|
I think this is ready to go for now. I threw a bunch of different URLs at it and it was able to correctly set the properties. There may be some mf2 markup I haven't accounted for though. I know I need to improve mine. |
|
nice, thanks! I will check my links too and merge it if will also work. |
|
Hoping to close a lot of issues with this |
| // check u-* params | ||
| if ( in_array( $key, array_keys( $classes ) ) ) { | ||
| // check "normal" links | ||
| if ( self::compare_urls( $target, $values ) ) { | ||
| // if ( self::compare_urls( $target, $values ) ) { |
There was a problem hiding this comment.
you can't remove this line, because if you do, the function returns the first matching class, if the link matches or not.
There was a problem hiding this comment.
It has to be checked, because this example for target: http://example.com/webmention/target/placeholder is returning reply but it should return like.
<span class="h-entry">
<a class="u-in-reply-to" href="http://example.com/">A Cool Post</a><a class="u-url" href="/"></a>
<a class="u-like-of" href="http://example.com/webmention/target/placeholder">A Cool Post</a><a class="u-url" href="/"></a>
<a class="u-in-reply-to" href="http://example.com/">A Cool Post</a><a class="u-url" href="/"></a>
</span>There was a problem hiding this comment.
or this example returns bookmark but it should be a mention (target: http://example.com/webmention/target/placeholder):
<span class="h-entry">
<a class="u-bookmark-of" href="http://example.com/">A Cool Post</a><a class="u-url" href="/"></a>
<a href="http://example.com/webmention/target/placeholder">A Cool Post</a><a class="u-url" href="/"></a>
</span>
| public static function get_entries( $mf_array ) { | ||
| $entries = array(); | ||
|
|
||
| public static function get_representative_item( $mf_array, $target ) { |
There was a problem hiding this comment.
this is called for getting the representative h-entry and h-card, so we shouldn't mix both. This might cause errors because it might return the author as h-entry and the other way around. The author stuff should be part of get_representative_author.
There was a problem hiding this comment.
Which is being called for both the h-card and the h-entry?
…e string it will set it to now
|
I made some minor modifications. Do you have any URLs to test it against? The ones I threw at it, it seemed to work. |
|
I tested your changes with the testpinger (https://github.com/voxpelli/node-webmention-testpinger) examples and nearly no type is detected correctly. |
|
The author detection seems to work better though. |
|
Odd. Think maybe I should close this and go back to the drawing board with a simpler design? |
|
I'm going to go back to the drawing board and integrate the changes in smaller steps. |
|
what do you think about the following steps:
|
|
I'm working on a slightly less intrusive version of the refactorings. But if you commit your tests, I can always rebase. |
This fixes the misclassification of other properties as mentions, but also starts the process of reconfiguring the mf2 portion of the plugin to store properties in comment meta.
Assuming this particular improvement is going in the right direction, future commits would continue enhancing the authorship code(to pull a remote author URL if needed), as well as other enhancements to allow for enhanced display and additional types in the future, as appropriate.