This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
facepiles: make sure avatars are always visible images #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to move the code to the avatar code, to have a better encapsulation |
|
sure! will do. |
fixes pfefferle#116 If the WordPress default avatar setting is 'blank', switch it to a visible placeholder, since this is a facepile. Also inject a JS fallback to a visible placeholder image, since webmention author images are usually remote, and can disappear over time.
snarfed
force-pushed
the
visible_default_avatar
branch
from
580a60e
to
892f99d
Compare
i had to do this, instead of the earlier code that used wordpress's `get_avatar` filter, because i only want it to run for facepile avatar images, and i couldn't find a way to pass a flag through to the `get_avatar` filter to tell it whether the current avatar is in a facepile or not.
...e.g. when the browser has tracking protection on and blocks loading the gravatar URL, which re-triggers the onerror handler.
|
ok! it's better encapsulated now. not in |
|
yay thank you! |
snarfed
referenced
this pull request
in snarfed/wordpress-semantic-linkbacks
Nov 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #116
If the WordPress default avatar setting is
blank, switch it to a visible placeholder, since this is a facepile. Also inject a JS fallback to a visible placeholder image, since webmention author images are usually remote, and can disappear over time.screenshot: