Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontpage processing for person tags to be accepted & setting default to sync #115

Closed
wants to merge 4 commits into from

Conversation

acegiak
Copy link

@acegiak acegiak commented Jan 27, 2017

No description provided.

@pfefferle
Copy link
Owner

this merge request is very confusing ;)

is the only change, the sync flag?

@dshanske
Copy link
Collaborator

I think that @acegiak wants the Page ID for the homepage to be settable by user option, not just filter. I think that is doable.

@acegiak
Copy link
Author

acegiak commented Jan 27, 2017

Nono I ended up using the hook to do that in a different thread.

The only two things this PR are for are setting the default to sync rather than async and allowing the webmention endpoint to be displayed on the front page so that you can receive person tags

@dshanske
Copy link
Collaborator

@acegiak I see.. not showing it is creating an issue for exotic Webmentions.

@dshanske
Copy link
Collaborator

I think I have another way to approach this.

@dshanske
Copy link
Collaborator

Let me give it a go

@pfefferle
Copy link
Owner

Is there perhaps a generic way? like an action or a hook? I don't want to add features that are not used by the core, but by a plugin instead.

@dshanske
Copy link
Collaborator

That is what I am thinking. Make the is_singular and pings_open check a function, and filter it. So anyone can open it for any given URL.

@pfefferle pfefferle closed this Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants