Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes Python3.5 "yield in async function" errors #5

Closed
wants to merge 1 commit into from

Conversation

ph1l
Copy link

@ph1l ph1l commented Aug 1, 2017

fixes #4 but breaks tests.

I don't quite understand all this async stuff, or how to fix this test:

=========================================== ERRORS ============================================
_____________________ ERROR collecting secret_handshake/test_boxstream.py _____________________
.eggs/pytest-3.1.3-py3.5.egg/_pytest/python.py:408: in _importtestmodule
    mod = self.fspath.pyimport(ensuresyspath=importmode)
.eggs/py-1.4.34-py3.5.egg/py/_path/local.py:662: in pyimport
    __import__(modname)
E     File "/home/elektron/code/PySecretHandshake/secret_handshake/test_boxstream.py", line 74
E       assert [msg async for msg in unbox_stream] == [b'foo', b'foo', b'bar']
E                       ^
E   SyntaxError: invalid syntax
!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!
=================================== 1 error in 0.20 seconds ===================================

@coveralls
Copy link

coveralls commented Aug 1, 2017

Coverage Status

Coverage decreased (-0.5%) to 79.521% when pulling f28f6c9 on ph1l:fix_yield_inside_async_func into e70324e on pferreir:master.

@pferreir pferreir closed this Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests fail on Debian Stretch
3 participants