Implement basic referrer parsing

pfleidi · Jan 31, 2016 · 7c13ae3 · 7c13ae3
1 parent 9377727
commit 7c13ae3
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 4 deletions.
diff --git a/lib/stats_extractor.js b/lib/stats_extractor.js
@@ -1,11 +1,22 @@
 'use strict';
 
+const url = require('url');
 const parseUserAgent = require('./user_agent_parser');
 
 module.exports = function statsExtractor(req, res) {
 
+  function parseReferrer(referrer) {
+    if (referrer === 'unknown') {
+      return 'unknown';
+    }
+
+    return url.parse(referrer).host;
+  }
+
   function exctractStatistics(transferState, duration, sentBytes) {
     let referrer = req.headers.referrer || 'unknown';
+    let parsedReferrer = parseReferrer(referrer);
+
     let userAgent = req.headers['user-agent'] || 'unknown';
     let parsedUserAgent = parseUserAgent(userAgent);
 
@@ -19,7 +30,7 @@ module.exports = function statsExtractor(req, res) {
       raw_user_agent: userAgent,
       parsed_user_agent: parsedUserAgent,
       raw_referrer: referrer,
-      parsed_referrer: '?'
+      parsed_referrer: parsedReferrer
     };
   }
 

diff --git a/test/unit/stats_extractor_test.js b/test/unit/stats_extractor_test.js
@@ -29,7 +29,7 @@ describe('statsExtractor', function () {
     raw_user_agent: 'unknown',
     parsed_user_agent: 'Other',
     raw_referrer: 'unknown',
-    parsed_referrer: '?'
+    parsed_referrer: 'unknown'
   };
 
   const exctractStatistics = statsExtractor(req, res);
@@ -64,12 +64,35 @@ describe('statsExtractor', function () {
     it('returns a response with the correctly parsed user agent', function () {
       let stats = exctractStatistics('canceled', duration, sentBytes);
 
-      let expectedStats = _.merge(expectedStatsTemplate, {
+      let expectedStats = _.assign({}, expectedStatsTemplate, {
         raw_user_agent: userAgent,
         parsed_user_agent: 'Chrome'
       });
 
-      assert.deepEqual(stats, expectedStatsTemplate);
+      assert.deepEqual(stats, expectedStats);
+    });
+  });
+
+  describe('with a referrer', function () {
+    let referrer = 'http://blog.binaergewitter.de/';
+
+    before(function () {
+      req.headers.referrer = referrer;
+    });
+
+    after(function () {
+      req.headers.referrer = null;
+    });
+
+    it('returns a response with the correctly parsed user agent', function () {
+      let stats = exctractStatistics('canceled', duration, sentBytes);
+
+      let expectedStats = _.assign({}, expectedStatsTemplate, {
+        raw_referrer: referrer,
+        parsed_referrer: 'blog.binaergewitter.de'
+      });
+
+      assert.deepEqual(stats, expectedStats);
     });
   });