Fix kotlin tests #24
Fix kotlin tests #24
Conversation
|
It would be great if this PR included a scripted test that illustrates this working. |
README.md
Outdated
| @@ -40,6 +40,7 @@ Current version 1.0.8 | |||
| `kotlinVersion` | |||
| plugin | |||
| * `kotlincOptions`: options to pass to the kotlin compiler | |||
| * `definedTests in Test := KotlinTest.kotlinTests.value`: specifies kotlin test classes | |||
There was a problem hiding this comment.
this seems unnecessary to document unless there's a specific user-need that they would want to override this?
There was a problem hiding this comment.
Yes, this line doesn't have sense because I have added in the kotlinSettings. I will remove it. 💯
src/main/scala/KotlinPlugin.scala
Outdated
| @@ -68,6 +68,7 @@ object KotlinPlugin extends AutoPlugin { | |||
| classDirectory.value, streams.value) | |||
| }.dependsOn (compileInputs in (Compile,compile)).value, | |||
| compile := (compile dependsOn kotlinCompile).value, | |||
| kotlinSource := sourceDirectory.value / "kotlin" | |||
| kotlinSource := sourceDirectory.value / "kotlin", | |||
| definedTests in Test := KotlinTest.kotlinTests.value | |||
There was a problem hiding this comment.
will this clobber existing definitions of definedTests? if so, perhaps the correct approach would be to use ++= rather than :=
src/main/scala/KotlinTest.scala
Outdated
|
|
||
| object KotlinTest { | ||
| val kotlinTests = Def.task { | ||
| val old = (definedTests in Test).value |
There was a problem hiding this comment.
I see why := was used in the settings. I'd rather this switch to ignoring old and using ++= instead.
There was a problem hiding this comment.
Yes, you are right, It was my first version ^^
|
I did the changes you suggested and I added a two tests |
src/main/scala/KotlinTest.scala
Outdated
| val loader = ClasspathUtilities.toLoader((fullClasspath in Test).value map { | ||
| _.data | ||
| }) | ||
| val log = sLog.value |
There was a problem hiding this comment.
oops, didn't notice this before, instead use streams.value.log
src/sbt-test/kotlin/basic-tests/test
Outdated
| @@ -0,0 +1,3 @@ | |||
| > compile | |||
| > test | |||
| > "test-only *SimpleTest" | |||
There was a problem hiding this comment.
It would be great if you could also verify that target/test-reports/SimpleTest.xml and target/test-reports/demo.JavaCalculator.xml gets created with expected contents
src/sbt-test/kotlin/mixed-tests/test
Outdated
| @@ -0,0 +1,3 @@ | |||
| > compile | |||
| > test | |||
| > "test-only *MixedTest" | |||
|
I have checked if there is something failure test 👍 |
* Show an example code in Play Framework using sbt in kotlin. * Uses the new version of [kotlin-plugin for sbt](https://github.com/pfn/kotlin-plugin) we implemented here pfn/kotlin-plugin#24 to run kotlin tests. * Show running test in kotlin with sbt * Database tests using H2 * End to End tests using H2 * Uses [karumi/ktlint-sbt](https://github.com/Karumi/ktlint-sbt) plugin
Motivation
While using the plugin, we have found that when you run
sbt testthe plugin isn't able to find the test classes. This doesn't let us execute our test written in kotlin.Implementation
I have added a KotlintTest class to find kotlin test classes, KotlinTest class should be located in the
sbtpackage to access to some sbt protected objects and methods likesbt.classfile.AnalyzeUsage
To be able to run the test using this plugin you only need to add the
definedTests in Test := KotlinTest.kotlinTests.valueline inbuild.sbt.