Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shape and Scalar type to ChxVMVar #289

Merged
merged 6 commits into from
May 29, 2019

Conversation

take-cheeze
Copy link
Contributor

@take-cheeze
Copy link
Contributor Author

Making the output of Shape operator chainerx::Shape seems to be a good start point to use this

Copy link
Member

@shinh shinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm guessing introducing these types would make the following faster:

$ PYTHONPATH=ch2o python3 ch2o/tests/model/EspNet_E2E.py --recipe csj_medium --gen csj_medium --gpu
$ ./build/tools/run_onnx --test csj_medium_backprop --backprop -d cuda -I 10 --fuse_operations --use_nvrtc
Average elapsed: 192.045 msec

Hmm it used to be 100ms or so. Maybe there were some regressions.

The following command runs the same network by Chainer for reference:

$ PYTHONPATH=ch2o python3 ch2o/tests/model/EspNet_E2E.py --recipe csj_medium --run --gpu
Elapsed: 4776.919364929199 msec
Elapsed: 203.45425605773926 msec
Elapsed: 209.4278335571289 msec
Elapsed: 212.3851776123047 msec
Elapsed: 209.69533920288086 msec
Elapsed: 223.52290153503418 msec
Elapsed: 209.55896377563477 msec
Elapsed: 211.23909950256348 msec
Elapsed: 208.7113857269287 msec
Elapsed: 209.62882041931152 msec
Average elapsed: 210.84708637661404 msec

@shinh shinh merged commit 1e049fc into pfnet-research:master May 29, 2019
@take-cheeze take-cheeze deleted the specialize_chxvm_var branch May 30, 2019 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add scalar/shape types to XCVMVar
2 participants