Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: implicit args for Black-Scholes modules #516

Merged
13 commits merged into from
Mar 9, 2022

Conversation

masanorihirano
Copy link
Collaborator

No description provided.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I think we want that feature.

pfhedge/nn/modules/bs/european.py Outdated Show resolved Hide resolved
pfhedge/nn/modules/bs/european.py Outdated Show resolved Hide resolved
Co-authored-by: simaki <shota.imaki.0801@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2022

Codecov Report

Merging #516 (a64319f) into main (5c71d6f) will decrease coverage by 0.02%.
The diff coverage is 98.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   99.51%   99.48%   -0.03%     
==========================================
  Files          50       50              
  Lines        1871     1960      +89     
==========================================
+ Hits         1862     1950      +88     
- Misses          9       10       +1     
Impacted Files Coverage Δ
pfhedge/nn/modules/bs/_base.py 98.41% <97.29%> (-1.59%) ⬇️
pfhedge/nn/modules/bs/american_binary.py 100.00% <100.00%> (ø)
pfhedge/nn/modules/bs/european.py 100.00% <100.00%> (ø)
pfhedge/nn/modules/bs/european_binary.py 100.00% <100.00%> (ø)
pfhedge/nn/modules/bs/lookback.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c71d6f...a64319f. Read the comment docs.

@masanorihirano
Copy link
Collaborator Author

@simaki
Could you let me know this?:
#516 (comment)

@masanorihirano masanorihirano changed the title WIP: implicit args for BlackScholes implicit args for BlackScholes Mar 8, 2022
@masanorihirano
Copy link
Collaborator Author

@simaki I have finished this implementation.

@masanorihirano
Copy link
Collaborator Author

masanorihirano commented Mar 8, 2022

The missed coverage caused by #530 and #528 #529 also cause some issues in tests.
Tests for them are comment-out lines with ToDo notations.

@ghost ghost changed the base branch from main to develop March 9, 2022 04:04
@ghost ghost changed the title implicit args for BlackScholes ENH: implicit args for Black-Scholes modules Mar 9, 2022
@ghost ghost merged commit a034e2a into pfnet-research:develop Mar 9, 2022
ghost pushed a commit that referenced this pull request Mar 9, 2022
* ENH: Add `pfhedge.__version__` support (#514)

* ENH: Add Black-Scholes formulas as functional (#489) (#506)

* ENH: Add `end_index` to forward start payoff functional (#518)

* ENH: Add `clauses`, `named_clauses` to derivative (#520)

* ENH: implicit args for Black-Scholes modules (#516)

* ENH: Add bilinear interpolation function `bilerp` (close #523) (#527)

* ENH: Add `.float16()`, `.float32(), `.float64()` to Instrument (#524)

* BUG: Stop assigning arbitrary strike to autogreek.delta (#517)

* DOC: Update functional documentations (#508)

* DOC: Add note on discrete/continuous monitoring (#513)

* DOC: Add note on adding clause (#515)

* DOC: Elaborate documentation on payoff (#519)

* MAINT: Refactor BlackScholes module using factory (close #509) (#510)

* MAINT: Miscellaneous refactoring (#507) (#521) (#525)

* CHORE: Run Publish action on release (#504)

* Bumping version from 0.17.0 to 0.18.0 (#532)

Co-authored-by: Masanori HIRANO <masanorihirano@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants