FEAT: Matrix invert function #608
Conversation
cemoody
force-pushed
the
moody/matrixops
branch
2 times, most recently
from
765c76a
to
360b2a1
Compare
| import six | ||
| import numpy.linalg | ||
|
|
||
| import cupy |
There was a problem hiding this comment.
Please remove this line. Chainer must not directly import the cupy. Use the chainer.cuda.cupy.
For example,
https://github.com/pfnet/chainer/blob/83800a77b9118fa4d7e98b03056a95f488e96a51/chainer/functions/array/select_item.py#L49
cemoody
force-pushed
the
moody/matrixops
branch
11 times, most recently
from
04d043b
to
a7bf8b3
Compare
|
OK, thanks for reviewing @okuta. I fixed the failing tests and changed |
cemoody
force-pushed
the
moody/matrixops
branch
3 times, most recently
from
bb1e38e
to
d59de3c
Compare
|
@cemoody Do you have time to work on this PR? Since it requires some knowledge to resolve conflicts, we will help you to fix the code. I am sorry to make you hurry, but we will work on sending you PR if no response is returned until the end of this week (1/8). |
|
@okuta Yes, please do send a PR. As you recognized, it's difficult for me to resolve the conflicts. If you send a PR, I'll be happy to review! Many thanks :) |
|
I'm sorry it takes a long time to fix. |
Fix matrixops for cupy v1.5
|
LGTM! |
Implemented a batch matrix inversion function. Addresses part of #575, but that still needs to support a determinant function