Make type check utilities#95
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
If get_type is not called only from get_types, I think get_type should be in get_types to narrow its scope.
Member
Author
|
In offline discussion, we decided to use this style: |
Member
There was a problem hiding this comment.
Can I write in_types[0].ndim.eval > self.axis instead? I think it is better because value of the left hand side is used afterwards as ndim.
Member
There was a problem hiding this comment.
By offline discussion, I found that it is necessary to wrap self.axis in order to print variable name axis when this expectation failed.
Member
There was a problem hiding this comment.
Bool is misunderstanding with bool (True or False)
Member
|
LGTM 👍 |
niboshi
pushed a commit
to niboshi/chainer
that referenced
this pull request
Jun 24, 2017
Implement slogdet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function. The function is called with expression treesfixes #1
For example, when 4th dimension of 1st argument of an input is expected to be 2, you can write like this:
And, actually it is 1, a user can get a error message like this: