Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the document of JournalStorage #4308

Merged
merged 1 commit into from Jan 10, 2023

Conversation

hrntsm
Copy link
Contributor

@hrntsm hrntsm commented Jan 5, 2023

Motivation

JournalStorage sometimes does not work well in a Windows environment and I would like to document the solution.

Description of the changes

The content in #4298 was reflected in the document.

@github-actions github-actions bot added the optuna.storages Related to the `optuna.storages` submodule. This is automatically labeled by github-actions. label Jan 5, 2023
@nzw0301 nzw0301 added the document Documentation related. label Jan 5, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4308 (02fa77d) into master (2a48efa) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4308      +/-   ##
==========================================
+ Coverage   89.62%   89.63%   +0.01%     
==========================================
  Files         170      170              
  Lines       13367    13367              
==========================================
+ Hits        11980    11982       +2     
+ Misses       1387     1385       -2     
Impacted Files Coverage Δ
optuna/storages/_journal/storage.py 97.27% <ø> (ø)
optuna/integration/botorch.py 97.55% <0.00%> (+0.81%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c-bata c-bata added this to the v3.1.0 milestone Jan 6, 2023
@HideakiImamura HideakiImamura self-assigned this Jan 6, 2023
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related. optuna.storages Related to the `optuna.storages` submodule. This is automatically labeled by github-actions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants