Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add force_type=None option to pfio.v2.from_url() #211

Closed
kuenishi opened this issue Sep 27, 2021 · 0 comments · Fixed by #218
Closed

Add force_type=None option to pfio.v2.from_url() #211

kuenishi opened this issue Sep 27, 2021 · 0 comments · Fixed by #218
Labels
cat:enhancement Implementation that does not break interfaces.
Milestone
2.0.0

Comments

@kuenishi
Copy link
Member

  • In some cases, a zip file without .zip extension want to be opened
  • Current behaviour of .from_url() is somewhat fizzy; if just a file (non-zip, non-directory) is passed, it should fail (but it doesn't). It fails when the first time it is manipulated.
@kuenishi kuenishi added this to the 2.0.0 milestone Sep 27, 2021
@kuenishi kuenishi mentioned this issue Sep 29, 2021
Merged
@kuenishi kuenishi added the cat:enhancement Implementation that does not break interfaces. label Oct 1, 2021
@kuenishi kuenishi closed this as completed Oct 1, 2021
@kuenishi kuenishi linked a pull request Oct 1, 2021 that will close this issue
Add force_type option to from_url #218
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cat:enhancement Implementation that does not break interfaces.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Add force_type option to from_url pfnet/pfio
1 participant
@kuenishi