check pid in zip #105
Merged
check pid in zip #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belldandyxtq
reviewed
Jan 8, 2020
|
/test |
1 similar comment
|
/test |
|
Successfully created a job for commit 6259dfd: |
belldandyxtq
requested changes
Jan 16, 2020
|
/test |
|
Successfully created a job for commit 2c38b0c: |
|
/test |
|
Successfully created a job for commit 433cd75: |
belldandyxtq
requested changes
Jan 17, 2020
chainerio/containers/zip.py
Outdated
| @@ -80,12 +94,14 @@ def _wrap_fileobject(self, file_obj: Type['IOBase'], | |||
| def open(self, file_path, mode='r', | |||
| buffering=-1, encoding=None, errors=None, | |||
| newline=None, closefd=True, opener=None): | |||
| if sys.version_info < (3, 6) and "w" in mode: | |||
| raise ValueError('Mode w and wb is not supported') | |||
There was a problem hiding this comment.
Can you mention that "w" and "wb" is not supported only in Python < 3.6?
|
/test |
|
Successfully created a job for commit 2ef8e26: |
|
/test |
|
Successfully created a job for commit 596fffe: |
|
/test |
|
Successfully created a job for commit a7ebe0e: |
belldandyxtq
approved these changes
Jan 20, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves
ZipContainerissue in #104