Normalize input path in zip isdir
#83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belldandyxtq
added
cat:test
5 tasks
The `isdir` simply forwards the input to `stat` and relies on `stat` to normalize the input path. To align with the behavior of `os.path.isdir`, False is returned when the given file or directory does not exist.
belldandyxtq
force-pushed
the
normalize_path_isdir
branch
from
2914c80
to
8fc845b
Compare
belldandyxtq
changed the title
isdirisdir
kuenishi
requested changes
Dec 2, 2019
kuenishi
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isdirsimply forwards the input tostatand relies onstatto normalize the input path.
To align with the behavior of
os.path.isdir, False is returned whenthe given file or directory does not exist.