Use keytab by environment variable #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belldandyxtq
requested changes
Nov 29, 2019
chainerio/filesystems/hdfs.py
Outdated
| self.keytab_path = keytab_path | ||
| if self.keytab_path is None: | ||
| self.keytab_path = os.getenv("CHAINERIO_KEYTAB") |
There was a problem hiding this comment.
How about renaming it "CHAINERIO_HDFS_KEYTAB"?
docs/source/reference.rst
Outdated
| @@ -28,14 +28,22 @@ Toplevel Functions | |||
| .. autoclass:: chainerio.container.Container | |||
| :members: | |||
|
|
|||
|
|
|||
| .. note:: With environment variable | |||
| ``CHAINERIO_KEYTAB=path/to/your.keytab`` set, ``hdfs`` | |||
|
I have changed the whole design to use |
| # variable. If /etc/krb5.keytab doesn't exist, krbticket | ||
| # tries to update the ticket with ``kinit -R`` as much as | ||
| # possible. | ||
| self.ticket = KrbTicket.init(self.username) |
There was a problem hiding this comment.
Is the update needed when we do not have the keytab?
There was a problem hiding this comment.
Please read the code comment above
There was a problem hiding this comment.
I meant do we have to update the ticket even if we do not have the keytab?
There was a problem hiding this comment.
Yes. Ticket expiration date can be renewable until renewable date by kinit -R and the former is usually earlier than latter, like hours or days.
belldandyxtq
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.