Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filterwarnings in some onnx tests #197

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Conversation

asi1024
Copy link
Member

@asi1024 asi1024 commented Jun 21, 2021

Part #193

@kmaehashi
Copy link
Member

Can we narrow down the filter a bit more? (maybe limit to torch.floor_divide)

@@ -142,6 +142,7 @@ def _fn2(x):


@pytest.mark.filterwarnings("ignore::torch.jit.TracerWarning")
@pytest.mark.filterwarnings("ignore::UserWarning")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecation warning of torch.floor_divide raised from here: https://github.com/pytorch/pytorch/blob/v1.9.0/torch/nn/functional.py#L2358

@@ -62,6 +62,7 @@ def _helper(model, args, d, **kwargs):
return output_dir


@pytest.mark.filterwarnings("ignore::UserWarning")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An experimental warning for named tensors is raised, but this test looks not to use named tensor 🤔

UserWarning: Named tensors and all their associated APIs are an experimental feature and subject to change. Please do not use them for anything important until they are released as stable. (Triggered internally at  /pytorch/c10/core/TensorImpl.h:1156.)

@asi1024 asi1024 mentioned this pull request Jun 21, 2021
9 tasks
emcastillo pushed a commit to emcastillo/pytorch-pfn-extras that referenced this pull request Jun 22, 2021
Sync github master to PPE
@asi1024
Copy link
Member Author

asi1024 commented Jun 23, 2021

@kmaehashi Could you take another look?

@kmaehashi
Copy link
Member

Could you resolve conflicts? LGTM otherwise!

@kmaehashi
Copy link
Member

/test

Copy link
Member

@kmaehashi kmaehashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kmaehashi kmaehashi merged commit ff566c8 into pfnet:master Jun 28, 2021
@asi1024 asi1024 deleted the filterwarning branch June 28, 2021 07:10
@kmaehashi kmaehashi added this to the v0.4.2 milestone Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants