Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable problematic check #15

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Disable problematic check #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion version_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ void VersionBuilder::Add(Elf_Versym versym, const std::string& soname, const std
}

if (is_special_ver_ndx(versym)) {
CHECK(soname.empty() && version.empty()) << " excess soname or version information is given.";
// TODO(joe): Consider again whether we should allow this.
// Currently, this check may fail when a symbol with nonempty soname and version is resolved by
// fallback on another symbol where is_special_ver_ndx(versym) == true in SymtabBuilder::Resolve.
// CHECK(soname.empty() && version.empty()) << " excess soname or version information is given.";
Comment on lines +28 to +31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made issue #16

LOG(INFO) << "VersionBuilder::" << special_ver_ndx_to_str(versym);

vers.push_back(versym);
Expand Down
Loading