Fix type annotation for LineItemType enum #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The annotation says it would expect an instance of LineItemType. But it expects a string (a constant from the LineItemType). This currently fails any autocomplete and static analysis. Using LineItemType::* fixes this as allowed by phpstan, see https://phpstan.org/writing-php-code/phpdoc-types#literals-and-constants But in general the same problem seems to apply to all enums in this library, e.g. also TransactionState. Is this generated code? Then it needs to be fixed in the generator I assume.
|
@Tobion thank you for the update. We will take an overall look at the enum annotations on the PHP sdk. |
|
@vttn any news one this one? It might also make sense to create a new version of the library requiring php 8.1 that can make use of native php enums. |
|
Hello @Tobion, We looked into changing the annotations and we discovered that the work around could not be found to apply this to all SDK classes in the library. We are working on bringing out PHP 8.1 soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The annotation says it would expect an instance of LineItemType. But it expects a string (a constant from the LineItemType).
This currently fails any autocomplete and static analysis.
Using LineItemType::* fixes this as allowed by phpstan, see https://phpstan.org/writing-php-code/phpdoc-types#literals-and-constants
But in general the same problem seems to apply to all enums in this library, e.g. also TransactionState.
Is this generated code? Then it needs to be fixed in the generator I assume.