Replace system() calls by direct libnotify library calls. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ced image files by standard icon names.
|
@pfps Any objections/questions/remarks about this pull request? |
pfps
added a commit
that referenced
this pull request
Dec 1, 2015
Replace system() calls by direct libnotify library calls.
|
Looks OK, I pulled it. peter On 11/29/2015 06:09 AM, Christoph Hertzberg wrote:
|
|
In my case, sensors and touchpad don't work after a reboot. This was why I originally opened #51 |
|
This is probably due to some not-quite-correct initialization of your hardware. I don't know what it responsible for the initialization (if anything). You may want to open a new thing devoted to this topic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dependency on libnotify-dev. If you don't like this, please remove the fork() call, or replace the system() call by a corresponding execl() call -- otherwise, you'll spawn a new thread for every new notification which is never killed.
Also, if the icons I chose don't work generically (they work on ubuntu+xfce, I did not test anything else), feel free to change them (though the previous values will have worked on even fewer systems g)