Extending the discouraged functions list #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klausi
requested changes
May 14, 2020
coder_sniffer/Drupal/Sniffs/Functions/DiscouragedFunctionsSniff.php
Outdated
Show resolved
Hide resolved
|
PHPstan tests are failing here, can you merge in the 8.x-3.x branch? |
|
Hi Klausi, As far as I can see I'm up-to-date with the 8.x-3.x branch. |
|
phpstan tests fails are on the 8.x-3.x branch, fixed them there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ksm, kint, and ddbug_backtrace to the list of discouraged functions.
Related to these 3 issues on Drupal.org
https://www.drupal.org/project/coder/issues/3129320.
https://www.drupal.org/project/coder/issues/3129343
https://www.drupal.org/project/coder/issues/3129344