Simplify $EXTERNAL_NET variable declaration to match Snort change

pfsense · Nov 10, 2023 · f40e5cb · f40e5cb
1 parent d2cd4ad
commit f40e5cb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/security/pfSense-pkg-suricata/files/usr/local/pkg/suricata/suricata_generate_yaml.php b/security/pfSense-pkg-suricata/files/usr/local/pkg/suricata/suricata_generate_yaml.php
@@ -53,10 +53,7 @@
 	$external_net = "[" . trim($external_net) . "]";
 }
 else {
-	$external_net = "[";
-	foreach ($home_net_list as $ip)
-		$external_net .= "!{$ip}, ";
-	$external_net = trim($external_net, ', ') . "]";
+	$external_net = "[!\$HOME_NET]";
 }
 
 // Set the PASS LIST and write its contents to disk,

diff --git a/security/pfSense-pkg-suricata/files/usr/local/www/suricata/suricata_list_view.php b/security/pfSense-pkg-suricata/files/usr/local/www/suricata/suricata_list_view.php
@@ -68,7 +68,7 @@
 	elseif ($type == "externalnet") {
 		if ($wlist == "default") {
 			$list = suricata_build_list($a_rule, $a_rule['homelistname']);
-			$contents = "";
+			$contents = "Defined in suricata.yaml as: !\$HOME_NET which expands to:\n\n";
 			foreach ($list as $ip)
 				$contents .= "!{$ip}\n";
 			$contents = trim($contents, "\n");