Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bug #13214 AttributeError: 'NoneType' object has no attribute 'text' #1168

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

indgy
Copy link

@indgy indgy commented May 24, 2022

This fix resolves bug #13214

I was seeing this error on my pfsense install with ArpWatch enabled

This code checks the element exists before trying to assign the text value, if it does not exist an empty string is assigned instead.

@jim-p
Copy link
Contributor

jim-p commented May 24, 2022

To effectively track changes and bug/feature requests, we require an entry on the pfSense Redmine issue tracker associated with every pull request, and likewise the Redmine entry should also have a link back to the pull request.

Please associate this PR to a Redmine issue either by locating an existing issue at https://redmine.pfsense.org or by creating a new issue. Add a link to the Redmine issue that points to this PR, and also add a link on the PR to the Redmine issue.

For more information, see https://docs.netgate.com/pfsense/en/latest/development/pull-request.html
Thanks!

@indgy indgy changed the title Fix: AttributeError: 'NoneType' object has no attribute 'text' Fix: Bug #13214 AttributeError: 'NoneType' object has no attribute 'text' May 25, 2022
@jim-p
Copy link
Contributor

jim-p commented May 25, 2022

As a part of this pull request, you must increase PORTVERSION or add a PORTREVISION line in the package Makefile. Without this version increase, the package will not be rebuilt to include the new change.

See https://docs.netgate.com/pfsense/en/latest/references/developer-style-guide.html#ports-packages-specific-rules

@indgy
Copy link
Author

indgy commented May 25, 2022

Apologies I am not familiar with the FreeBSD port make process, I've bumped the port revision number.

There is an issue reported by portlint but it existed before my edits
FATAL: Makefile: [1]: $FreeBSD$ is deprecated in Git.

Shall I remove that line in this PR too?

@jim-p
Copy link
Contributor

jim-p commented May 26, 2022

There is an issue reported by portlint but it existed before my edits FATAL: Makefile: [1]: $FreeBSD$ is deprecated in Git.

Shall I remove that line in this PR too?

That can be left alone, no need to worry about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants