pfSense-pkg-livekit: add initial support for livekit server #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI features: * Set main port * Set API key * Set API secret * Generate token with parameters (room, identity, validity) Signed-off-by: Andrés MANELLI <amanelli@forssea-robotics.fr>
Signed-off-by: Andrés MANELLI <amanelli@forssea-robotics.fr>
|
@andresmanelli this looks awesome! To simplify port setup, it might be good to use single-port UDP here by specifying rtc.udp_port. |
Signed-off-by: Andrés MANELLI <amanelli@forssea-robotics.fr>
Signed-off-by: Andrés MANELLI <amanelli@forssea-robotics.fr>
|
Thanks for the input @davidzhao, I pushed the update (and the screenshot). |
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[EDIT] Redmine: https://redmine.pfsense.org/issues/14583
UI features:
I got inspiration from other packages, but there is certainly room for improvement.
Please let me know if there's anything to be done. Tested with 2.7.0
Thanks!
cc @davidzhao
[EDIT]: Screenshots if anyone's interested