pfBlockerNG: Support AdBlock Whitelists with wildcards #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrebrait
force-pushed
the
pfblockerng_devel_whitelist
branch
from
6017ca8
to
642c9bd
Compare
|
I caught an issue with the Python mode yesterday. Fixing it later today. EDIT: fixed in 8042e88 |
* Use less memory, write whitelist to disk right away * Fix regular expression conversion to disallow matching limiter chars * Do not recreate whitelist file for each alias
* Use a dedicated log file for whitelisting results * Restrict detailed view on whitelisted domains to log file * Make the new file visible via the Logs page
andrebrait
force-pushed
the
pfblockerng_devel_whitelist
branch
from
151f5f6
to
5f69f6e
Compare
|
Closed this one as I'll be sending a more complete one instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this draft PR for early commenting
So far, I've tested it for Unbound mode. Likely needs some small adjustments for Python mode. I'll be testing it soon.
I need some special help with testing it and with the log message formatting. I'm not very happy with how it looks right now, but I whipped this together somewhat quickly, so beauty wasn't my priority.
Add support for AdBlock-style exclusions/whitelisting for pfBlockerNG.
While it already supported AdBlock-style blacklists (minus wildcards), whitelists weren't a thing. This PR adds support for them (including wildcards, since there's not much complexity in doing that) through filtering out the domain lists, exactly like what it does with user-defined whitelists, but expanding that to use Regular Expressions, allowing it to support wildcard entries.
Missing yet:
Next changes I plan on making, assuming this PR turns out ok: