Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zabbix-proxy - Nuke PBI junk #20

Merged
merged 5 commits into from
Dec 9, 2015
Merged

zabbix-proxy - Nuke PBI junk #20

merged 5 commits into from
Dec 9, 2015

Conversation

doktornotor
Copy link
Contributor

No description provided.

@netgate-git-updates netgate-git-updates merged commit 5aac020 into pfsense:devel Dec 9, 2015
jim-p added a commit that referenced this pull request Dec 9, 2015
@doktornotor doktornotor deleted the patch-7 branch December 9, 2015 13:29
netgate-git-updates pushed a commit that referenced this pull request Apr 30, 2016
  * Fix a build failure when building without YAJL support (#47, #49).

  * dnsqr: Also perform query name filtering for UDP_UNSOLICITED_RESPONSE
    messages (#48).

  * dnsqr: Remove 'icmp' from the generated BPF (#20, #50).

  * dnsqr: Only set 'resolver_address_zeroed' field if addresses were zeroed
    from the underlying query/response packet fields (#51). Resolver address
    zeroing only works for the UDP message types, so we were incorrectly
    setting the 'resolver_address_zeroed' field for TCP and ICMP messages.

  * nmsg-dnsqr2pcap: Also dump ICMP and TCP packets (#52).

 -- Robert Edmonds <edmonds@fsi.io>  Fri, 29 Apr 2016 13:37:40 -0400

Sponsored by:	Farsight Security, Inc.
netgate-git-updates pushed a commit that referenced this pull request Jul 1, 2017
 - Add license headers to code files (fixes i#17)
 - Remove mercurial files (fixes #20)

PR:		220401
Submitted by:	Vladimir Krstulja <vlad-fbsd@acheronmedia.com> (maintainer)
Approved by:	garga (mentor, implicit)
netgate-git-updates pushed a commit that referenced this pull request Jun 30, 2020
No PORTEPOCH bump because this port wasn't stable to begin with.

* thread #9, name = 'yuzu:CPUThread', stop reason = signal SIGABRT
  * frame #0: 0x0000000804146a8a libc.so.7`__sys_thr_kill at thr_kill.S:4
    frame #1: 0x0000000804146424 libc.so.7`__raise(s=6) at raise.c:52:10
    frame #2: 0x00000008040aef19 libc.so.7`abort at abort.c:67:8
    frame #3: 0x00000008038f39b9 libcxxrt.so.1`report_failure(err=<unavailable>, thrown_exception=0x00000009d701aa88) at exception.cc:719:5
    frame #4: 0x00000008038c34dc libc++.so.1`std::__1::__throw_system_error(ev=11, what_arg="mutex lock failed") at system_error.cpp:287:5
    frame #5: 0x00000008038a834d libc++.so.1`std::__1::mutex::lock(this=<unavailable>) at mutex.cpp:35:9
    frame #6: 0x0000000000dbb534 yuzu`std::__1::unique_lock<std::__1::mutex>::unique_lock(this=0x00000009c68f1d90, __m=0x0000000805984918) at __mutex_base:119:61
    frame #7: 0x000000000136167d yuzu`Service::NVFlinger::NVFlinger::Lock(this=0x000000080c8c6958) at nvflinger.h:90:16
    frame #8: 0x00000000014c5ab4 yuzu`Service::VI::IHOSBinderDriver::TransactParcel(this=0x00000009d536e6f8, thread=std::__1::shared_ptr<Kernel::Thread>::element_type @ 0x000000090faedc20 strong=9 weak=2, ctx=0x00000009d536e310, reason=Signal)::'lambda'(std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)::operator()(std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason) const at vi.cpp:554:37
    frame #9: 0x00000000014c59f5 yuzu`decltype(__f=0x00000009d536e6f8, __args=nullptr, __args=0x00000009d536e310, __args=0x00000009c68f2004)::'lambda'(std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)&>(fp)(std::__1::forward<std::__1::shared_ptr<Kernel::Thread> >(fp0), std::__1::forward<Kernel::HLERequestContext&>(fp0), std::__1::forward<Kernel::ThreadWakeupReason>(fp0))) std::__1::__invoke<Service::VI::IHOSBinderDriver::TransactParcel(Kernel::HLERequestContext&)::'lambda'(std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)&, std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason>(Service::VI::IHOSBinderDriver::TransactParcel(Kernel::HLERequestContext&)::'lambda'(std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)&, std::__1::shared_ptr<Kernel::Thread>&&, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason&&) at type_traits:3539:1
    frame #10: 0x00000000014c594c yuzu`void std::__1::__invoke_void_return_wrapper<void>::__call<Service::VI::IHOSBinderDriver::TransactParcel(__args=0x00000009d536e6f8, __args=nullptr, __args=0x00000009d536e310, __args=0x00000009c68f2004)::'lambda'(std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)&, std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason>(Service::VI::IHOSBinderDriver::TransactParcel(Kernel::HLERequestContext&)::'lambda'(std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)&, std::__1::shared_ptr<Kernel::Thread>&&, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason&&) at __functional_base:348:9
    frame #11: 0x00000000014c58dc yuzu`std::__1::__function::__alloc_func<Service::VI::IHOSBinderDriver::TransactParcel(Kernel::HLERequestContext&)::'lambda'(std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason), std::__1::allocator<Service::VI::IHOSBinderDriver::TransactParcel(Kernel::HLERequestContext&)::'lambda'(std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)>, void (std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)>::operator(this=0x00000009d536e6f8, __arg=nullptr, __arg=0x00000009d536e310, __arg=0x00000009c68f2004)(std::__1::shared_ptr<Kernel::Thread>&&, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason&&) at functional:1540:16
    frame #12: 0x00000000014c480d yuzu`std::__1::__function::__func<Service::VI::IHOSBinderDriver::TransactParcel(Kernel::HLERequestContext&)::'lambda'(std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason), std::__1::allocator<Service::VI::IHOSBinderDriver::TransactParcel(Kernel::HLERequestContext&)::'lambda'(std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)>, void (std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)>::operator(this=0x00000009d536e6f0, __arg=nullptr, __arg=0x00000009d536e310, __arg=0x00000009c68f2004)(std::__1::shared_ptr<Kernel::Thread>&&, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason&&) at functional:1714:12
    frame #13: 0x0000000001116862 yuzu`std::__1::__function::__value_func<void (std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)>::operator(this=0x00000009d536e6f0, __args=nullptr, __args=0x00000009d536e310, __args=0x00000009c68f2004)(std::__1::shared_ptr<Kernel::Thread>&&, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason&&) const at functional:1867:16
    frame #14: 0x00000000011167bc yuzu`std::__1::function<void (std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)>::operator(this= Lambda in File vi.cpp at Line 552, __arg=<unavailable>, __arg=0x00000009d536e310, __arg=Signal)(std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason) const at functional:2473:12
    frame #15: 0x000000000110a6a4 yuzu`Kernel::HLERequestContext::SleepClientThread(this=0x00000009d536e310, thread=std::__1::shared_ptr<Kernel::Thread>::element_type @ 0x000000090faedc20 strong=9 weak=2)>&&, std::__1::shared_ptr<Kernel::WritableEvent>)::$_0::operator()(std::__1::shared_ptr<Kernel::Thread>) at hle_ipc.cpp:67:17
    frame #16: 0x000000000110a5b1 yuzu`decltype(__f=0x00000009d536e310, __args=nullptr)>&&, std::__1::shared_ptr<Kernel::WritableEvent>)::$_0&>(fp)(std::__1::forward<std::__1::shared_ptr<Kernel::Thread> >(fp0))) std::__1::__invoke<Kernel::HLERequestContext::SleepClientThread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned long, std::__1::function<void (std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)>&&, std::__1::shared_ptr<Kernel::WritableEvent>)::$_0&, std::__1::shared_ptr<Kernel::Thread> >(Kernel::HLERequestContext::SleepClientThread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned long, std::__1::function<void (std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)>&&, std::__1::shared_ptr<Kernel::WritableEvent>)::$_0&, std::__1::shared_ptr<Kernel::Thread>&&) at type_traits:3539:1
    frame #17: 0x000000000110a532 yuzu`bool std::__1::__invoke_void_return_wrapper<bool>::__call<Kernel::HLERequestContext::SleepClientThread(__args=0x00000009d536e310, __args=nullptr)>&&, std::__1::shared_ptr<Kernel::WritableEvent>)::$_0&, std::__1::shared_ptr<Kernel::Thread> >(Kernel::HLERequestContext::SleepClientThread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned long, std::__1::function<void (std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)>&&, std::__1::shared_ptr<Kernel::WritableEvent>)::$_0&, std::__1::shared_ptr<Kernel::Thread>&&) at __functional_base:317:16
    frame #18: 0x000000000110a4f2 yuzu`std::__1::__function::__alloc_func<Kernel::HLERequestContext::SleepClientThread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned long, std::__1::function<void (std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)>&&, std::__1::shared_ptr<Kernel::WritableEvent>)::$_0, std::__1::allocator<Kernel::HLERequestContext::SleepClientThread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned long, std::__1::function<void (std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)>&&, std::__1::shared_ptr<Kernel::WritableEvent>)::$_0>, bool (std::__1::shared_ptr<Kernel::Thread>)>::operator(this=0x00000009d536e310, __arg=nullptr)(std::__1::shared_ptr<Kernel::Thread>&&) at functional:1540:16
    frame #19: 0x00000000011094b3 yuzu`std::__1::__function::__func<Kernel::HLERequestContext::SleepClientThread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned long, std::__1::function<void (std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)>&&, std::__1::shared_ptr<Kernel::WritableEvent>)::$_0, std::__1::allocator<Kernel::HLERequestContext::SleepClientThread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned long, std::__1::function<void (std::__1::shared_ptr<Kernel::Thread>, Kernel::HLERequestContext&, Kernel::ThreadWakeupReason)>&&, std::__1::shared_ptr<Kernel::WritableEvent>)::$_0>, bool (std::__1::shared_ptr<Kernel::Thread>)>::operator(this=0x00000009d536e300, __arg=nullptr)(std::__1::shared_ptr<Kernel::Thread>&&) at functional:1714:12
    frame #20: 0x00000000011834ed yuzu`std::__1::__function::__value_func<bool (std::__1::shared_ptr<Kernel::Thread>)>::operator(this=0x000000090faee1c0, __args=nullptr)(std::__1::shared_ptr<Kernel::Thread>&&) const at functional:1867:16
    frame #21: 0x0000000001180c18 yuzu`std::__1::function<bool (std::__1::shared_ptr<Kernel::Thread>)>::operator(this=0x000000090faee1c0, __arg=<unavailable>)(std::__1::shared_ptr<Kernel::Thread>) const at functional:2473:12
    frame #22: 0x000000000117edb2 yuzu`Kernel::Thread::InvokeHLECallback(this=0x000000090faedc20, thread=nullptr) at thread.cpp:403:12
    frame #23: 0x00000000011929d7 yuzu`Kernel::Svc::SendSyncRequest(system=0x000000000252f3d8, handle=622615) at svc.cpp:365:17
    frame #24: 0x000000000118b3b5 yuzu`void Kernel::SvcWrap64<&(Kernel::Svc::SendSyncRequest(Core::System&, unsigned int))>(system=0x000000000252f3d8) at svc_wrap.h:50:24
    frame #25: 0x000000000118a334 yuzu`Kernel::Svc::Call(system=0x000000000252f3d8, immediate=33) at svc.cpp:2649:13
    frame #26: 0x00000000011a60e3 yuzu`Core::DynarmicCallbacks64::CallSVC(this=0x00000009c657df60, swi=33) at arm_dynarmic_64.cpp:123:9
    frame #27: 0x00000000023f2c74 yuzu`Dynarmic::Backend::X64::impl::ThunkBuilder<void (Dynarmic::A64::UserCallbacks::*)(unsigned int), &(Dynarmic::A64::UserCallbacks::CallSVC(unsigned int))>::Thunk(this_=0x00000009c657df60, args=33) at devirtualize.h:28:16
netgate-git-updates pushed a commit that referenced this pull request Jun 4, 2022
/usr/bin/cc -I. -isystem /usr/local/include -DHAVE_CONFIG_H -O2 -pipe  -I/usr/include -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -ggdb3 -Wall -W -Wno-sign-compare   -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes   -Wpointer-arith -Wbad-function-cast -Wnested-externs -fpic -MT chacha-4core.o -MD -MP -MF chacha-4core.o.d -c chacha-4core.s
chacha-4core.s:125:23: error: invalid operand for instruction
        add             v24.4s, v24.4s, v160.4s
                                        ^
chacha-4core.s:126:7: error: invalid operand for instruction
        add             v163.4s, v163.4s, v164.4s
                        ^
chacha-4core.s:129:7: error: invalid operand for instruction
        eor             v162.16b, v162.16b, v24.16b
                        ^
chacha-4core.s:130:7: error: invalid operand for instruction
        eor             v166.16b, v166.16b, v163.16b
                        ^
chacha-4core.s:133:8: error: invalid operand for instruction
        rev32   v162.8h, v162.8h
                ^
chacha-4core.s:134:8: error: invalid operand for instruction
        rev32   v166.8h, v166.8h
                ^
chacha-4core.s:138:7: error: invalid operand for instruction
        add             v161.4s, v161.4s, v162.4s
                        ^
chacha-4core.s:139:7: error: invalid operand for instruction
        add             v165.4s, v165.4s, v166.4s
                        ^
chacha-4core.s:142:15: error: invalid operand for instruction
        eor             v6.16b, v160.16b, v161.16b
                                ^
chacha-4core.s:143:15: error: invalid operand for instruction
        eor             v7.16b, v164.16b, v165.16b
                                ^
chacha-4core.s:146:7: error: invalid operand for instruction
        ushr    v160.4s, v6.4s, #20
                ^
chacha-4core.s:147:7: error: invalid operand for instruction
        ushr    v164.4s, v7.4s, #20
                ^
chacha-4core.s:150:7: error: invalid operand for instruction
        sli             v160.4s, v6.4s, #12
                        ^
chacha-4core.s:151:7: error: invalid operand for instruction
        sli             v164.4s, v7.4s, #12
                        ^
chacha-4core.s:155:23: error: invalid operand for instruction
        add             v24.4s, v24.4s, v160.4s
                                        ^
chacha-4core.s:156:7: error: invalid operand for instruction
        add             v163.4s, v163.4s, v164.4s
                        ^
chacha-4core.s:159:7: error: invalid operand for instruction
        eor             v162.16b, v162.16b, v24.16b
                        ^
chacha-4core.s:160:7: error: invalid operand for instruction
        eor             v166.16b, v166.16b, v163.16b
                        ^
chacha-4core.s:163:18: error: vector register expected
        tbl             v162.16b, {v162.16b}, v8.16b
                                   ^
chacha-4core.s:163:26: error: unknown token in expression
        tbl             v162.16b, {v162.16b}, v8.16b
                                           ^
chacha-4core.s:163:26: error: invalid operand
        tbl             v162.16b, {v162.16b}, v8.16b
                                           ^
chacha-4core.s:164:18: error: vector register expected
        tbl             v166.16b, {v166.16b}, v8.16b
                                   ^
chacha-4core.s:164:26: error: unknown token in expression
        tbl             v166.16b, {v166.16b}, v8.16b
                                           ^
chacha-4core.s:164:26: error: invalid operand
        tbl             v166.16b, {v166.16b}, v8.16b
                                           ^
chacha-4core.s:168:7: error: invalid operand for instruction
        add             v161.4s, v161.4s, v162.4s
                        ^
chacha-4core.s:169:7: error: invalid operand for instruction
        add             v165.4s, v165.4s, v166.4s
                        ^
chacha-4core.s:172:15: error: invalid operand for instruction
        eor             v6.16b, v160.16b, v161.16b
                                ^
chacha-4core.s:173:15: error: invalid operand for instruction
        eor             v7.16b, v164.16b, v165.16b
                                ^
chacha-4core.s:176:7: error: invalid operand for instruction
        ushr    v160.4s, v6.4s, #25
                ^
chacha-4core.s:177:7: error: invalid operand for instruction
        ushr    v164.4s, v7.4s, #25
                ^
chacha-4core.s:180:7: error: invalid operand for instruction
        sli             v160.4s, v6.4s, #7
                        ^
chacha-4core.s:181:7: error: invalid operand for instruction
        sli             v164.4s, v7.4s, #7
                        ^
chacha-4core.s:186:23: error: invalid operand for instruction
        add             v24.4s, v24.4s, v160.4s
                                        ^
chacha-4core.s:187:7: error: invalid operand for instruction
        add             v163.4s, v163.4s, v164.4s
                        ^
chacha-4core.s:190:7: error: invalid operand for instruction
        eor             v162.16b, v162.16b, v24.16b
                        ^
chacha-4core.s:191:7: error: invalid operand for instruction
        eor             v166.16b, v166.16b, v163.16b
                        ^
chacha-4core.s:194:8: error: invalid operand for instruction
        rev32   v162.8h, v162.8h
                ^
chacha-4core.s:195:8: error: invalid operand for instruction
        rev32   v166.8h, v166.8h
                ^
chacha-4core.s:199:7: error: invalid operand for instruction
        add             v161.4s, v161.4s, v162.4s
                        ^
chacha-4core.s:200:7: error: invalid operand for instruction
        add             v165.4s, v165.4s, v166.4s
                        ^
chacha-4core.s:203:15: error: invalid operand for instruction
        eor             v6.16b, v160.16b, v161.16b
                                ^
chacha-4core.s:204:15: error: invalid operand for instruction
        eor             v7.16b, v164.16b, v165.16b
                                ^
chacha-4core.s:207:7: error: invalid operand for instruction
        ushr    v160.4s, v6.4s, #20
                ^
chacha-4core.s:208:7: error: invalid operand for instruction
        ushr    v164.4s, v7.4s, #20
                ^
chacha-4core.s:211:7: error: invalid operand for instruction
        sli             v160.4s, v6.4s, #12
                        ^
chacha-4core.s:212:7: error: invalid operand for instruction
        sli             v164.4s, v7.4s, #12
                        ^
chacha-4core.s:216:23: error: invalid operand for instruction
        add             v24.4s, v24.4s, v160.4s
                                        ^
chacha-4core.s:217:7: error: invalid operand for instruction
        add             v163.4s, v163.4s, v164.4s
                        ^
chacha-4core.s:220:7: error: invalid operand for instruction
        eor             v162.16b, v162.16b, v24.16b
                        ^
chacha-4core.s:221:7: error: invalid operand for instruction
        eor             v166.16b, v166.16b, v163.16b
                        ^
chacha-4core.s:224:18: error: vector register expected
        tbl             v162.16b, {v162.16b}, v8.16b
                                   ^
chacha-4core.s:224:26: error: unknown token in expression
        tbl             v162.16b, {v162.16b}, v8.16b
                                           ^
chacha-4core.s:224:26: error: invalid operand
        tbl             v162.16b, {v162.16b}, v8.16b
                                           ^
chacha-4core.s:225:18: error: vector register expected
        tbl             v166.16b, {v166.16b}, v8.16b
                                   ^
chacha-4core.s:225:26: error: unknown token in expression
        tbl             v166.16b, {v166.16b}, v8.16b
                                           ^
chacha-4core.s:225:26: error: invalid operand
        tbl             v166.16b, {v166.16b}, v8.16b
                                           ^
chacha-4core.s:229:7: error: invalid operand for instruction
        add             v161.4s, v161.4s, v162.4s
                        ^
chacha-4core.s:230:7: error: invalid operand for instruction
        add             v165.4s, v165.4s, v166.4s
                        ^
chacha-4core.s:233:15: error: invalid operand for instruction
        eor             v6.16b, v160.16b, v161.16b
                                ^
chacha-4core.s:234:15: error: invalid operand for instruction
        eor             v7.16b, v164.16b, v165.16b
                                ^
chacha-4core.s:237:7: error: invalid operand for instruction
        ushr    v160.4s, v6.4s, #25
                ^
chacha-4core.s:238:7: error: invalid operand for instruction
        ushr    v164.4s, v7.4s, #25
                ^
chacha-4core.s:241:7: error: invalid operand for instruction
        sli             v160.4s, v6.4s, #7
                        ^
chacha-4core.s:242:7: error: invalid operand for instruction
        sli             v164.4s, v7.4s, #7
                        ^
netgate-git-updates pushed a commit that referenced this pull request Dec 4, 2023
Added:
* Check for duplicate / re-used passwords
* Add option to limit checks to specific filename

Changed:
* Simplify the audit process
* Use setup.py to manage the full installation and deprecate the
  Makefile

Fixed:
* Terminate the GnuPG commandline as it could potentially be a security
  issue.
* Multiple minor fixes: #20, 21, #25

Changelog:
https://github.com/roddhjav/pass-audit/blob/master/CHANGELOG.md
PR:		275534
Approved by:	submitter is maintainer
netgate-git-updates pushed a commit that referenced this pull request Apr 22, 2024
* thread #1, name = 'xdg-desktop-port', stop reason = signal SIGSEGV: address not mapped to object (fault address: 0x0)
    frame #0: 0x000000000026acf0 xdg-desktop-portal-hyprland`dmabufFeedbackMainDevice(data=0x0000000000000000, feedback=0x0000182398a105c0, device_arr=0x0000182398a891d0) at PortalManager.cpp:90:5
   87   static void dmabufFeedbackMainDevice(void* data, zwp_linux_dmabuf_feedback_v1* feedback, wl_array* device_arr) {
   88       Debug::log(LOG, "[core] dmabufFeedbackMainDevice");
   89
-> 90       RASSERT(!g_pPortalManager->m_sWaylandConnection.gbm, "double dmabuf feedback");
   91
   92       dev_t device;
   93       assert(device_arr->size == sizeof(device));
(lldb) bt
* thread #1, name = 'xdg-desktop-port', stop reason = signal SIGSEGV: address not mapped to object (fault address: 0x0)
  * frame #0: 0x000000000026acf0 xdg-desktop-portal-hyprland`dmabufFeedbackMainDevice(data=0x0000000000000000, feedback=0x0000182398a105c0, device_arr=0x0000182398a891d0) at PortalManager.cpp:90:5
    frame #1: 0x000000082c61067a libffi.so.8`ffi_call_unix64 at unix64.S:104
    frame #2: 0x000000082c60f8f9 libffi.so.8`ffi_call_int(cif=0x0000000820fbba80, fn=(xdg-desktop-portal-hyprland`dmabufFeedbackMainDevice(void*, zwp_linux_dmabuf_feedback_v1*, wl_array*) at PortalManager.cpp:87), rvalue=0x0000000000000000, avalue=0x0000000820fbbab0, closure=0x0000000000000000) at ffi64.c:673:3
    frame #3: 0x000000082c60f452 libffi.so.8`ffi_call(cif=0x0000000820fbba80, fn=(xdg-desktop-portal-hyprland`dmabufFeedbackMainDevice(void*, zwp_linux_dmabuf_feedback_v1*, wl_array*) at PortalManager.cpp:87), rvalue=0x0000000000000000, avalue=0x0000000820fbbab0) at ffi64.c:710:3
    frame #4: 0x00000008242fac28 libwayland-client.so.0`wl_closure_invoke(closure=0x0000182398a89100, flags=1, target=0x0000182398a105c0, opcode=2, data=0x0000000000000000) at connection.c:1025:2
    frame #5: 0x00000008242f84cf libwayland-client.so.0`dispatch_event(display=0x0000182398a1b140, queue=0x0000182398a1b230) at wayland-client.c:1631:3
    frame #6: 0x00000008242f72f4 libwayland-client.so.0`dispatch_queue(display=0x0000182398a1b140, queue=0x0000182398a1b230) at wayland-client.c:1777:3
    frame #7: 0x00000008242f70bd libwayland-client.so.0`wl_display_dispatch_queue_pending(display=0x0000182398a1b140, queue=0x0000182398a1b230) at wayland-client.c:2019:8
    frame #8: 0x00000008242f6c8e libwayland-client.so.0`wl_display_dispatch_queue(display=0x0000182398a1b140, queue=0x0000182398a1b230) at wayland-client.c:1995:9
    frame #9: 0x00000008242f6814 libwayland-client.so.0`wl_display_roundtrip_queue(display=0x0000182398a1b140, queue=0x0000182398a1b230) at wayland-client.c:1403:9
    frame #10: 0x00000008242f6ce0 libwayland-client.so.0`wl_display_roundtrip(display=0x0000182398a1b140) at wayland-client.c:1432:9
    frame #11: 0x0000000000326718 xdg-desktop-portal-hyprland`CToplevelManager::activate(this=0x0000182398a19240) at ToplevelManager.cpp:109:5
    frame #12: 0x0000000000267b72 xdg-desktop-portal-hyprland`CPortalManager::onGlobal(this=0x0000182398a1b000, data=0x0000000000000000, registry=0x0000182398a10440, name=24, interface="zwlr_foreign_toplevel_manager_v1", version=3) at PortalManager.cpp:261:34
    frame #13: 0x00000000002675e5 xdg-desktop-portal-hyprland`handleGlobal(data=0x0000000000000000, registry=0x0000182398a10440, name=24, interface="zwlr_foreign_toplevel_manager_v1", version=3) at PortalManager.cpp:20:23
    frame #14: 0x000000082c61067a libffi.so.8`ffi_call_unix64 at unix64.S:104
    frame #15: 0x000000082c60f8f9 libffi.so.8`ffi_call_int(cif=0x0000000820fbc140, fn=(xdg-desktop-portal-hyprland`handleGlobal(void*, wl_registry*, unsigned int, char const*, unsigned int) at PortalManager.cpp:19), rvalue=0x0000000000000000, avalue=0x0000000820fbc170, closure=0x0000000000000000) at ffi64.c:673:3
    frame #16: 0x000000082c60f452 libffi.so.8`ffi_call(cif=0x0000000820fbc140, fn=(xdg-desktop-portal-hyprland`handleGlobal(void*, wl_registry*, unsigned int, char const*, unsigned int) at PortalManager.cpp:19), rvalue=0x0000000000000000, avalue=0x0000000820fbc170) at ffi64.c:710:3
    frame #17: 0x00000008242fac28 libwayland-client.so.0`wl_closure_invoke(closure=0x0000182398a1b8c0, flags=1, target=0x0000182398a10440, opcode=0, data=0x0000000000000000) at connection.c:1025:2
    frame #18: 0x00000008242f84cf libwayland-client.so.0`dispatch_event(display=0x0000182398a1b140, queue=0x0000182398a1b230) at wayland-client.c:1631:3
    frame #19: 0x00000008242f72f4 libwayland-client.so.0`dispatch_queue(display=0x0000182398a1b140, queue=0x0000182398a1b230) at wayland-client.c:1777:3
    frame #20: 0x00000008242f70bd libwayland-client.so.0`wl_display_dispatch_queue_pending(display=0x0000182398a1b140, queue=0x0000182398a1b230) at wayland-client.c:2019:8
    frame #21: 0x00000008242f6c8e libwayland-client.so.0`wl_display_dispatch_queue(display=0x0000182398a1b140, queue=0x0000182398a1b230) at wayland-client.c:1995:9
    frame #22: 0x00000008242f6814 libwayland-client.so.0`wl_display_roundtrip_queue(display=0x0000182398a1b140, queue=0x0000182398a1b230) at wayland-client.c:1403:9
    frame #23: 0x00000008242f6ce0 libwayland-client.so.0`wl_display_roundtrip(display=0x0000182398a1b140) at wayland-client.c:1432:9
    frame #24: 0x00000000002689a4 xdg-desktop-portal-hyprland`CPortalManager::init(this=0x0000182398a1b000) at PortalManager.cpp:312:5
    frame #25: 0x00000000002a3f76 xdg-desktop-portal-hyprland`main(argc=1, argv=0x0000000820fbc870, envp=0x0000000820fbc880) at main.cpp:38:23
    frame #26: 0x000000082a0172aa libc.so.7`__libc_start1(argc=1, argv=0x0000000820fbc870, env=0x0000000820fbc880, cleanup=<unavailable>, mainX=(xdg-desktop-portal-hyprland`main at main.cpp:15)) at libc_start1.c:157:7
    frame #27: 0x0000000000267520 xdg-desktop-portal-hyprland`_start at crt1_s.S:83

* thread #1, name = 'xdg-desktop-port', stop reason = signal SIGILL: privileged opcode
    frame #0: 0x0000000824c5f7cf libc++.so.1`std::__1::mutex::unlock(this=<unavailable>) at mutex.cpp:39:3
   36   void mutex::unlock() noexcept {
   37     int ec = __libcpp_mutex_unlock(&__m_);
   38     (void)ec;
-> 39     _LIBCPP_ASSERT_VALID_EXTERNAL_API_CALL(
   40         ec == 0, "call to mutex::unlock failed. A possible reason is that the mutex wasn't locked");
   41   }
   42
(lldb) bt
* thread #1, name = 'xdg-desktop-port', stop reason = signal SIGILL: privileged opcode
  * frame #0: 0x0000000824c5f7cf libc++.so.1`std::__1::mutex::unlock(this=<unavailable>) at mutex.cpp:39:3
    frame #1: 0x00000000002691d3 xdg-desktop-portal-hyprland`CPortalManager::startEventLoop(this=0x000021aa1001b000) at PortalManager.cpp:424:48
    frame #2: 0x0000000000268f06 xdg-desktop-portal-hyprland`CPortalManager::init(this=0x000021aa1001b000) at PortalManager.cpp:335:5
    frame #3: 0x00000000002a3f56 xdg-desktop-portal-hyprland`main(argc=1, argv=0x0000000820d386c8, envp=0x0000000820d386d8) at main.cpp:38:23
    frame #4: 0x00000008274222aa libc.so.7`__libc_start1(argc=1, argv=0x0000000820d386c8, env=0x0000000820d386d8, cleanup=<unavailable>, mainX=(xdg-desktop-portal-hyprland`main at main.cpp:15)) at libc_start1.c:157:7
    frame #5: 0x0000000000267520 xdg-desktop-portal-hyprland`_start at crt1_s.S:83
(lldb) f 1
frame #1: 0x00000000002691d3 xdg-desktop-portal-hyprland`CPortalManager::startEventLoop(this=0x000021aa1001b000) at PortalManager.cpp:424:48
   421
   422      while (1) { // dbus events
   423          // wait for being awakened
-> 424          m_sEventLoopInternals.loopRequestMutex.unlock(); // unlock, we are ready to take events
   425
   426          std::unique_lock lk(m_sEventLoopInternals.loopMutex);
   427          if (m_sEventLoopInternals.shouldProcess == false) // avoid a lock if a thread managed to request something already since we .unlock()ed

PR:		278496
Reported by:	shurd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants