pfSense-pkg-suricata - Remove useless conf_mount_{ro,rw} calls, Fix SID mods list download #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
October 21, 2017 20:56
doktornotor
changed the title
|
Thanks for the fixes. I will take a look at the JavaScript code in the SID MODS tab file to see what's going on. Storing the SID mod files content in config.xml is OK with me, but it may take me a bit of time to get it coded up. One thing the current code allows that I would like to continue is the ability to have multiple named configurations (different disablesid.conf files with differing names, for example) to pick and choose from at will. Maintaining this when stored as Base64 encoded text in config.xml would mean using an array to store each entry so you can have name and then content for each item. |
netgate-git-updates
pushed a commit
that referenced
this pull request
Oct 10, 2019
- Pet portclippy while here Changelog: * First run and build fixes #482 #473 #467 #479 (maciejsszmigiero) * Add OTP (two factor authentication) support #327 #394 (Noettore) * Display passwords as QR codes #421 (frawi) * Renaming password #463 #469 (Noettore) * Correct font color with Dark themes #340 #476 (a-andreyev) * Sorted profiles dropdown as in #404 #472 (Noettore) PR: 241176 Submitted by: Anne Jan Brouwer <brouwer@annejan.com> (maintainer) Approved by: tz (mentor) Differential Revision: https://reviews.freebsd.org/D21973
netgate-git-updates
pushed a commit
that referenced
this pull request
May 31, 2021
[ Ilya Lipnitsky ]
* c_message.cc: Resolve name conflict between certain enums and oneofs
(#427).
* protobuf-c.h: Fix Windows DLL export issue with the
protobuf_c_empty_string symbol (#428).
* Standardize pkg-config for use by autotools and cmake, fix cmake tests
(#425).
* protobuf-c.c: Cast %lu args to unsigned long int (#429).
* protoc-c: Remove leading underscores from structs (#430).
* protoc-c: Fix shared lib build on windows, migrate from Travis CI to
GitHub Actions (#459).
* protobuf-c: Don't use ProtobufCWireType internally (#463).
* protoc-c: Add custom options support (#466).
* protobuf-c.c: Fix packed repeated bool parsing (#467).
[ Markus Engel ]
* Pack nested messages inline (#431).
[ Daniel Axtens ]
* Travis CI: Test on other platforms (#438).
[ Adam Cozzette ]
* Update the generator to fully qualify std::string (#443).
[ Piotr Pietraszkiewicz ]
* Install MSVC debug symbols alongside the protobuf-c.lib file (#456).
[ ihsinme ]
* Fix invalid unsigned arithmetic (#455).
[ Wolfram Rösler ]
* Avoid "unused function parameter" compiler warning (#453).
Sponsored by: Farsight Security, Inc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bmeeks8 - I (hopefully] fixed the SID mods list download with dad6474, it was appending HTML source code to the individual files, plus the gzip download did not work at all, because the same was appended to the tar.gz breaking it completely.
There are still multiple issues with the code here, e.g.
I don't really understand the javascript stuff being done here but it's badly broken. Frankly it'd be a whole lot better to store the files base64-encoded in config.xml, they are not exactly so huge that it'd be a significant problem.