Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug #9724 #669

Closed
wants to merge 9 commits into from
Closed

bug #9724 #669

wants to merge 9 commits into from

Conversation

kiokoman
Copy link
Contributor

@kiokoman kiokoman commented Sep 4, 2019

https://redmine.pfsense.org/issues/9724
start clog or tail if clog does not exist

jim-p
jim-p requested changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@jim-p jim-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather wait and see how @BBcan177 would prefer to solve this.

net/pfSense-pkg-pfBlockerNG-devel/files/usr/local/pkg/pfblockerng/pfblockerng.inc Outdated Show resolved Hide resolved
@rbgarga
Copy link
Member

rbgarga commented Sep 4, 2019

@BBcan177 it would be nice if the clog_pfb/tail_pfb link was created by the port itself and kept in PLIST. This way PHP files would not be used to create/remove them

@kiokoman
Copy link
Contributor Author

kiokoman commented Sep 4, 2019

Thanks for your patience, really appreciated. maybe we can leave this as a suggestion for @BBcan177
I'm just trying to contribute as much as I can. It's not my intention to "step on anybody's toes." :)

@BBcan177
Copy link
Contributor

BBcan177 commented Sep 5, 2019

Thanks @kiokoman, I decided to make a clean PR #670 and also made a few other changes to the code.

@BBcan177
Copy link
Contributor

BBcan177 commented Sep 5, 2019

@rbgarga

@BBcan177 it would be nice if the clog_pfb/tail_pfb link was created by the port itself and kept in PLIST. This way PHP files would not be used to create/remove them

Will do this for the next version.

@kiokoman kiokoman closed this Sep 5, 2019
netgate-git-updates pushed a commit that referenced this pull request Feb 18, 2024
@fraggerfox
www/jira-cli: Update to 1.5.1
84a61d9 
Changes since 1.4.0:

v1.5.1

- fix: Properly close created files by @beatbrot in #702
- fix: Skip auth type prompt if already set by @ankitpokhrel in #701

- @beatbrot made their first contribution in #702

Full Changelog: ankitpokhrel/jira-cli@v1.5.0...v1.5.1

v1.5.0

This release brings the support for mTLS authentication along with some other features like setting affects version, updating the estimate, etc.

- feat: Enable issue edit to read body from stdin by @erpel in #619
- feat: Affects version by @damianoneill in #642
- feat: Add mtls authentication for client certificate auth by @markhatc- in
  #615
- feat: Add support for updating the estimate by @chapmanc in #669

- fix: Issue with no-input on create by @ankitpokhrel in #655
- fix: Jira init broken due to authtype value by @ankitpokhrel in #694
- fix: Bring bearer back by @ankitpokhrel in #696
- fix: Respect jira timezone by @ankitpokhrel in #697

- chore: Bump go & alpine versions by @pbnj in #691
- ci: Upgrade workflow + linter by @ankitpokhrel in #695
- dep: Upgrade all by @ankitpokhrel in #643

- @erpel made their first contribution in #619
- @damianoneill made their first contribution in #642
- @pbnj made their first contribution in #691
- @chapmanc made their first contribution in #669

Full Changelog:
ankitpokhrel/jira-cli@v1.4.0...v1.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbgarga rbgarga rbgarga requested changes

@jim-p jim-p jim-p requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@kiokoman @rbgarga @BBcan177 @jim-p