Telegraf CA file creation fix. Issue #10218 #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-p
approved these changes
Jan 29, 2020
netgate-git-updates
pushed a commit
that referenced
this pull request
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redmine Issue: https://redmine.pfsense.org/issues/10218
Ready for review
I'm running the 2.4.5-RC with Telegraf package 0.9_1 and found that Telegraf wouldn't start when I have more then one CA in pfSense.
After checking the created telegraf.ca I found that there is a missing newline after the first certificate, so it looked like this:
-----END CERTIFICATE----------BEGIN CERTIFICATE-----
which is invalid.
The fix is quite simple, look at line 67 in telegraf.inc and change it from
$ca_pem .= base64_decode($ca['crt']);
to
$ca_pem .= base64_decode($ca['crt'])."\n";
actual fix by Grimson Gretzleburg