Add softflow 1.0.0 features - sampling and PSAMP export. Issue #10220 #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-p
requested changes
Jan 29, 2020
| @@ -56,6 +56,9 @@ function sync_package_softflowd() { | |||
| if (is_numericint($cf['hoplimit'])) { | |||
| $start .= " -L " . escapeshellarg($cf['hoplimit']); | |||
| } | |||
| if (is_numericint($cf['sample']) && $cf['sample'] > 0) { | |||
There was a problem hiding this comment.
$cf['sample'] > 0 should be surrounded by parenthesis.
Co-authored-by: <chrono@open-resource.org> Co-authored-by: <viktor@netgate.com>
jim-p
approved these changes
Jan 29, 2020
netgate-git-updates
pushed a commit
that referenced
this pull request
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redmine Issue: https://redmine.pfsense.org/issues/10220
Ready for review
Add sampling configuration to softflowd package:
Add PSAMP export:
see https://tools.ietf.org/html/rfc5476
original PR #700 can be closed
Co-authored-by: chrono@open-resource.org
Co-authored-by: viktor@netgate.com