LCDproc: Add a link status screen for each interface. Issue #8198 #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-p
requested changes
Feb 28, 2020
Comment on lines
494
to
495
| if ($ifinfo['status'] == "up" || | ||
| $ifinfo['status'] == "associated") { |
There was a problem hiding this comment.
Each test should be in parenthesis
Comment on lines
502
to
504
| if ($ifinfo['pppoelink'] == "up" || | ||
| $ifinfo['pptplink'] == "up" || | ||
| $ifinfo['l2tplink'] == "up") { |
There was a problem hiding this comment.
Each test should be in parenthesis
Comment on lines
1257
to
1258
| if ($ifLinkList == null) | ||
| $ifLinkList = build_interface_link_list(); |
There was a problem hiding this comment.
The body of this if needs braces around it.
jim-p
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redmine Issue: https://redmine.pfsense.org/issues/8198
Ready for review
The link screen is similar to the 'Interfaces' dashboard widget, displaying ipv4, ipv6, mac and link status for each interface.
This is fixed/resolved copy of the original PR #377 by @c-schwamborn